Java-side sensor polling getHandler() method simplification as per joth's comment.

Java-side sensor polling getHandler() method simplification as per joth's comment.

BUG=135804
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195840

[timvolodine, 2013-04-18 13:43:16]

Thanks Jonathan for the suggestion to improve the code!

[joth, 2013-04-18 17:26:26]

lgtm thanks for following that up!

https://codereview.chromium.org/14352008/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(right):

https://codereview.chromium.org/14352008/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:362:
synchronized (mHandlerLock) {
unless getHandler() is called from multiple threads (AFAICT it isn't) you can
remove mHandlerLock too now

[timvolodine, 2013-04-22 10:00:52]

https://codereview.chromium.org/14352008/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(right):

https://codereview.chromium.org/14352008/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:362:
synchronized (mHandlerLock) {
On 2013/04/18 17:26:26, joth wrote:
> unless getHandler() is called from multiple threads (AFAICT it isn't) you can
> remove mHandlerLock too now

In the transitional implementation (i.e. using shared memory instead of IPC)
device motion will probably use a separate polling thread, so will not remove
the lock for now. I've added a comment to do this once both motion and
orientation use one single thread.

[Peter Beverloo, 2013-04-22 15:06:45]

https://codereview.chromium.org/14352008/diff/7001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(right):

https://codereview.chromium.org/14352008/diff/7001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:362:
// TODO: Remove the mHandlerLock when sure that getHandler is not called from
multiple
Please add your name to the TODO to indicate that you know more about it.  In
order to not forget, could you also file a bug and refer it?

[timvolodine, 2013-04-23 12:11:35]

https://codereview.chromium.org/14352008/diff/7001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(right):

https://codereview.chromium.org/14352008/diff/7001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:362:
// TODO: Remove the mHandlerLock when sure that getHandler is not called from
multiple
On 2013/04/22 15:06:45, Peter Beverloo wrote:
> Please add your name to the TODO to indicate that you know more about it.  In
> order to not forget, could you also file a bug and refer it?

Done.

[Peter Beverloo, 2013-04-23 13:52:43]

lgtm.  Feel free to put this on the commit queue yourself.  For future
reference, please prefer "crbug.com/234282" over "crbug/234282" as the former
will be clickable in some editors.

[commit-bot: I haz the power, 2013-04-23 14:26:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14352008/12001

[commit-bot: I haz the power, 2013-04-23 17:53:55]

Change committed as 195840