gpu/command_buffer/build_gles2_cmd_buffer.py - Issue 1435183002: WebGL 2: fix the bug in invalidate-framebuffer.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1435183002: WebGL 2: fix the bug in invalidate-framebuffer.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed InvalidateFramebufferTarget in cmd buffer Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_implementation_impl_autogen.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/build_gles2_cmd_buffer.py

diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py

index 0cf742407ac37a461aa49f9aa0ff58ebb0be926d..283ece58e9ca56df1a1c9877110db7b6a2d0c677 100755

--- a/gpu/command_buffer/build_gles2_cmd_buffer.py

+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py

@@ -603,16 +603,6 @@ _NAMED_TYPE_INFO = {

'GL_RENDERBUFFER',

- 'InvalidateFrameBufferTarget': {

Zhenyao Mo 2015/11/13 03:18:11 You should not remove this. For invalidateFramebu

Ken Russell (switch to Gerrit) 2015/11/17 23:06:37 Actually it looks like this was changed in ES spec

yunchao 2015/11/19 01:42:59 Agreed.

- 'type': 'GLenum',

- 'valid': [

- 'GL_FRAMEBUFFER',

- ],

- 'invalid': [

- 'GL_DRAW_FRAMEBUFFER' ,

- 'GL_READ_FRAMEBUFFER' ,

- ],

- },

'RenderBufferTarget': {

'type': 'GLenum',

'valid': [