content/browser/accessibility/browser_accessibility_win_unittest.cc - Issue 1435113003: Make use of new AX name calc in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 1435113003: Make use of new AX name calc in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue with ariaTextAlternative Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/browser/accessibility/one_shot_accessibility_tree_search.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc

index 5049c14773c64ae30f28f59a4efafc1ab305880a..29886bc1444aeaca4d40bf93634b33ac9a9cd9f8 100644

--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc

@@ -348,13 +348,13 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {

ui::AXNodeData static_text1;

static_text1.id = 3;

static_text1.role = ui::AX_ROLE_STATIC_TEXT;

- static_text1.AddStringAttribute(ui::AX_ATTR_VALUE, line1);

+ static_text1.AddStringAttribute(ui::AX_ATTR_NAME, line1);

static_text1.child_ids.push_back(4);

ui::AXNodeData inline_box1;

inline_box1.id = 4;

inline_box1.role = ui::AX_ROLE_INLINE_TEXT_BOX;

- inline_box1.AddStringAttribute(ui::AX_ATTR_VALUE, line1);

+ inline_box1.AddStringAttribute(ui::AX_ATTR_NAME, line1);

std::vector<int32> word_start_offsets1;

word_start_offsets1.push_back(0);

word_start_offsets1.push_back(4);

@@ -365,18 +365,18 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {

ui::AXNodeData line_break;

line_break.id = 5;

line_break.role = ui::AX_ROLE_LINE_BREAK;

- line_break.AddStringAttribute(ui::AX_ATTR_VALUE, "\n");

+ line_break.AddStringAttribute(ui::AX_ATTR_NAME, "\n");

ui::AXNodeData static_text2;

static_text2.id = 6;

static_text2.role = ui::AX_ROLE_STATIC_TEXT;

- static_text2.AddStringAttribute(ui::AX_ATTR_VALUE, line2);

+ static_text2.AddStringAttribute(ui::AX_ATTR_NAME, line2);

static_text2.child_ids.push_back(7);

ui::AXNodeData inline_box2;

inline_box2.id = 7;

inline_box2.role = ui::AX_ROLE_INLINE_TEXT_BOX;

- inline_box2.AddStringAttribute(ui::AX_ATTR_VALUE, line2);

+ inline_box2.AddStringAttribute(ui::AX_ATTR_NAME, line2);

std::vector<int32> word_start_offsets2;

word_start_offsets2.push_back(0);

word_start_offsets2.push_back(5);