content/browser/accessibility/one_shot_accessibility_tree_search.cc - Issue 1435113003: Make use of new AX name calc in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/one_shot_accessibility_tree_search.cc

Issue 1435113003: Make use of new AX name calc in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue with ariaTextAlternative Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win_unittest.cc ('k') | content/browser/accessibility/touch_accessibility_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/one_shot_accessibility_tree_search.cc

diff --git a/content/browser/accessibility/one_shot_accessibility_tree_search.cc b/content/browser/accessibility/one_shot_accessibility_tree_search.cc

index 1757c99765715b4ec80cf32d8ff28c6f9eae624d..f3daa6b4753dae7c3e0c3d11a94e56c4d70efdf2 100644

--- a/content/browser/accessibility/one_shot_accessibility_tree_search.cc

+++ b/content/browser/accessibility/one_shot_accessibility_tree_search.cc

@@ -20,8 +20,6 @@ void GetNodeStrings(BrowserAccessibility* node,

strings->push_back(node->GetString16Attribute(ui::AX_ATTR_NAME));

if (node->HasStringAttribute(ui::AX_ATTR_DESCRIPTION))

strings->push_back(node->GetString16Attribute(ui::AX_ATTR_DESCRIPTION));

- if (node->HasStringAttribute(ui::AX_ATTR_HELP))

- strings->push_back(node->GetString16Attribute(ui::AX_ATTR_HELP));

if (node->HasStringAttribute(ui::AX_ATTR_VALUE))

strings->push_back(node->GetString16Attribute(ui::AX_ATTR_VALUE));

if (node->HasStringAttribute(ui::AX_ATTR_PLACEHOLDER))