Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: pkg/compiler/lib/src/universe/use.dart

Issue 1435053002: Register super field set explicitly in the universe. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Checked mode fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/universe/universe.dart ('k') | pkg/compiler/lib/src/world.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/universe/use.dart
diff --git a/pkg/compiler/lib/src/universe/use.dart b/pkg/compiler/lib/src/universe/use.dart
index b619d5a9672cb026bf41c8e1a3912d5db512e729..77c108441a4392c155323d5b3a4b3476a78673c9 100644
--- a/pkg/compiler/lib/src/universe/use.dart
+++ b/pkg/compiler/lib/src/universe/use.dart
@@ -70,6 +70,7 @@ enum StaticUseKind {
GENERAL,
STATIC_TEAR_OFF,
SUPER_TEAR_OFF,
+ SUPER_FIELD_SET,
FIELD_GET,
FIELD_SET,
CLOSURE,
@@ -160,12 +161,21 @@ class StaticUse {
return new StaticUse._(element, StaticUseKind.GENERAL);
}
- /// Write access of a super field or setter [element].
- factory StaticUse.superSet(Element element) {
+ /// Write access of a super field [element].
+ factory StaticUse.superFieldSet(FieldElement element) {
assert(invariant(element, element.isInstanceMember,
message: "Super set element $element must be an instance method."));
- assert(invariant(element, element.isField || element.isSetter,
- message: "Super set element $element must be a field or a setter."));
+ assert(invariant(element, element.isField,
+ message: "Super set element $element must be a field."));
+ return new StaticUse._(element, StaticUseKind.SUPER_FIELD_SET);
+ }
+
+ /// Write access of a super setter [element].
+ factory StaticUse.superSetterSet(SetterElement element) {
+ assert(invariant(element, element.isInstanceMember,
+ message: "Super set element $element must be an instance method."));
+ assert(invariant(element, element.isSetter,
+ message: "Super set element $element must be a setter."));
return new StaticUse._(element, StaticUseKind.GENERAL);
}
« no previous file with comments | « pkg/compiler/lib/src/universe/universe.dart ('k') | pkg/compiler/lib/src/world.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698