pkg/compiler/lib/src/ssa/codegen.dart - Issue 1435053002: Register super field set explicitly in the universe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 1435053002: Register super field set explicitly in the universe. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Checked mode fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/codegen.dart

diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart

index 69ee9c85266ab2d6ee554561096735444866e087..688030a2ccbaad531bc876bc6249400b3cff4d6f 100644

--- a/pkg/compiler/lib/src/ssa/codegen.dart

+++ b/pkg/compiler/lib/src/ssa/codegen.dart

@@ -1751,7 +1751,9 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

.withSourceInformation(node.sourceInformation);

if (node.isSetter) {

registry.registerStaticUse(

- new StaticUse.superSet(superElement));

+ superElement.isSetter

+ ? new StaticUse.superSetterSet(superElement)

+ : new StaticUse.superFieldSet(superElement));

use(node.value);

push(new js.Assignment(access, pop())

.withSourceInformation(node.sourceInformation));