Allow extensions to remove and override the bookmark shortcut key

chrome/browser/ui/views/accelerator_utils_views.cc

Index: chrome/browser/ui/views/accelerator_utils_views.cc
diff --git a/chrome/browser/ui/views/accelerator_utils_views.cc b/chrome/browser/ui/views/accelerator_utils_views.cc
index c2c77db65bd2fc03d7cbbce70e1445a91961f937..c8f1f18eccdcb9e7db0d549a02cd61a73390e337 100644
--- a/chrome/browser/ui/views/accelerator_utils_views.cc
+++ b/chrome/browser/ui/views/accelerator_utils_views.cc
@@ -6,6 +6,7 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/views/accelerator_table.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 namespace chrome {
@@ -24,4 +25,18 @@ bool IsChromeAccelerator(const ui::Accelerator& accelerator, Profile* profile) {
 
 #endif  // !USE_AURA
 
+ui::Accelerator GetChromeAcceleratorForCommandId(int command_id) {

[sky, 2014/02/04 22:52:54]

Accelerators handled in ash aren't covered here. Also some commands are not
handled via the accelerator table on windows but through app commands. See
BrowserView::GetCommandIDForAppCommandID.

[Mike Wittman, 2014/02/05 18:10:46]

I've added a check for Ash accelerators (and standard accelerators, and moved
the function to the _aura.cc file).

All of the command IDs associated with the app commands also have standard
keyboard accelerators, which would be returned by the function. I renamed the
function to GetPrimaryChromeAcceleratorForCommandId to emphasize that there may
be alternate accelerator keys.

[sky, 2014/02/06 16:03:16]

Ah, ok. Good point.

+  std::vector<chrome::AcceleratorMapping> accelerators =
+      chrome::GetAcceleratorList();
+
+  for (size_t i = 0; i < accelerators.size(); ++i) {
+    if (accelerators[i].command_id == command_id) {
+      return ui::Accelerator(accelerators[i].keycode,
+                             accelerators[i].modifiers);
+    }
+  }
+
+  return ui::Accelerator();
+}
+
 }  // namespace chrome