Allow extensions to remove and override the bookmark shortcut key

chrome/browser/ui/views/accelerator_utils_views.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/accelerators/accelerator.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/views/accelerator_table.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 namespace chrome {
 
 #if !defined(USE_AURA)
 
 bool IsChromeAccelerator(const ui::Accelerator& accelerator, Profile* profile) {
   Browser* browser = chrome::FindLastActiveWithProfile(
       profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
   if (!browser)
     return false;
   BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(
       browser->window()->GetNativeWindow());
   return browser_view->IsAcceleratorRegistered(accelerator);
 }
 
 #endif  // !USE_AURA
 
+ui::Accelerator GetChromeAcceleratorForCommandId(int command_id) {

[sky, 2014/02/04 22:52:54]

Accelerators handled in ash aren't covered here. Also some commands are not
handled via the accelerator table on windows but through app commands. See
BrowserView::GetCommandIDForAppCommandID.

[Mike Wittman, 2014/02/05 18:10:46]

I've added a check for Ash accelerators (and standard accelerators, and moved
the function to the _aura.cc file).

All of the command IDs associated with the app commands also have standard
keyboard accelerators, which would be returned by the function. I renamed the
function to GetPrimaryChromeAcceleratorForCommandId to emphasize that there may
be alternate accelerator keys.

[sky, 2014/02/06 16:03:16]

Ah, ok. Good point.

+  std::vector<chrome::AcceleratorMapping> accelerators =
+      chrome::GetAcceleratorList();
+
+  for (size_t i = 0; i < accelerators.size(); ++i) {
+    if (accelerators[i].command_id == command_id) {
+      return ui::Accelerator(accelerators[i].keycode,
+                             accelerators[i].modifiers);
+    }
+  }
+
+  return ui::Accelerator();
+}
+
 }  // namespace chrome