Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1434873005: GN: Enable NaCl on Mac (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Enable NaCl on Mac The GN build with NaCl enabled works on Mac now. BUG=545236 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg,mac_chromium_gn_rel,mac_chromium_gn_upload R=dpranke@chromium.org Committed: https://crrev.com/aac646a4593a4786d230b62e86f60f3fcf952854 Cr-Commit-Position: refs/heads/master@{#359224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Roland McGrath
5 years, 1 month ago (2015-11-12 00:49:32 UTC) #1
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-12 00:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434873005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434873005/1
5 years, 1 month ago (2015-11-12 00:53:59 UTC) #4
commit-bot: I haz the power
Transient error: Invalid delimiter in "mac_chromium_gn_dbg,mac_chromium_gn_rel,mac_chromium_gn_upload": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
5 years, 1 month ago (2015-11-12 00:54:00 UTC) #6
Dirk Pranke
technically, you didn't need the mac_chromium_gn_upload bot, but no harm done.
5 years, 1 month ago (2015-11-12 00:58:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434873005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434873005/1
5 years, 1 month ago (2015-11-12 01:00:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 03:14:11 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:03:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aac646a4593a4786d230b62e86f60f3fcf952854
Cr-Commit-Position: refs/heads/master@{#359224}

Powered by Google App Engine
This is Rietveld 408576698