Build NaCl in the CrOS GN builds and make sure "all" works

Build NaCl in the CrOS GN builds and make sure "all" works

Fixing "all" involved a tweak to remoting to not try to
build remote_assistance_host (which shouldn't be built
on CrOS and isn't in GYP).

R=petermayo@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org, bbudge@chromium.org, bbudge@chromium.org
BUG=433082
Committed: https://crrev.com/f1e91ca130c57fbabb2f990e640a6d0bc09214c2
Cr-Commit-Position: refs/heads/master@{#359921}

[Dirk Pranke, 2015-11-12 01:27:28]

Description was changed from

==========
Build NaCl in the CrOS GN builds.

R=petermayo@chromium.org, mcgrathr@chromium.org
BUG=433082
==========

to

==========
Build NaCl in the CrOS GN builds and make sure "all" works

Fixing "all" involved a tweak to remoting to not try to
build remote_assistance_host (which shouldn't be built
on CrOS and isn't in GYP).

R=petermayo@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org
BUG=433082
==========

[Dirk Pranke, 2015-11-12 01:27:28]

dpranke@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Dirk Pranke, 2015-11-12 01:27:35]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[Dirk Pranke, 2015-11-12 01:28:12]

Please take a look, I think this should work now (though we don't have any bots
that will build all to catch that yet, unfortunately).

[commit-bot: I haz the power, 2015-11-12 01:28:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417823006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417823006/20001

[Roland McGrath, 2015-11-12 01:33:15]

lgtm

[Dirk Pranke, 2015-11-12 01:37:48]

On 2015/11/12 01:33:15, Roland McGrath wrote:
> lgtm

Note that this patch depends on mcgrathr's mac-enabling patch to land first, in
order for the patch to apply cleanly.

[commit-bot: I haz the power, 2015-11-12 03:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 03:11:59]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-11-12 21:30:38]

sergeyu, ping?

[Dirk Pranke, 2015-11-13 23:30:45]

On 2015/11/12 21:30:38, Dirk Pranke wrote:
> sergeyu, ping?

ping again?

[Sergey Ulanov, 2015-11-16 18:29:17]

lgtm

[Dirk Pranke, 2015-11-16 19:05:55]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-11-16 19:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417823006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417823006/20001

[commit-bot: I haz the power, 2015-11-16 19:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 19:17:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2015-11-16 20:51:26]

Description was changed from

==========
Build NaCl in the CrOS GN builds and make sure "all" works

Fixing "all" involved a tweak to remoting to not try to
build remote_assistance_host (which shouldn't be built
on CrOS and isn't in GYP).

R=petermayo@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org
BUG=433082
==========

to

==========
Build NaCl in the CrOS GN builds and make sure "all" works

Fixing "all" involved a tweak to remoting to not try to
build remote_assistance_host (which shouldn't be built
on CrOS and isn't in GYP).

R=petermayo@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org,
bbudge@chromium.org
BUG=433082
==========

[Dirk Pranke, 2015-11-16 20:51:47]

Description was changed from

==========
Build NaCl in the CrOS GN builds and make sure "all" works

Fixing "all" involved a tweak to remoting to not try to
build remote_assistance_host (which shouldn't be built
on CrOS and isn't in GYP).

R=petermayo@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org,
bbudge@chromium.org
BUG=433082
==========

to

==========
Build NaCl in the CrOS GN builds and make sure "all" works

Fixing "all" involved a tweak to remoting to not try to
build remote_assistance_host (which shouldn't be built
on CrOS and isn't in GYP).

R=petermayo@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org,
bbudge@chromium.org, bbudge@chromium.org
BUG=433082
==========

[Dirk Pranke, 2015-11-16 20:51:47]

dpranke@chromium.org changed reviewers:
+ bbudge@chromium.org

[Dirk Pranke, 2015-11-16 20:52:12]

bbudge, can you give me OWNERS approval for the ppapi change?

[bbudge, 2015-11-16 21:12:28]

ppapi lgtm
Thanks Dirk!

[Dirk Pranke, 2015-11-16 21:18:15]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-11-16 21:18:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417823006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417823006/20001

[commit-bot: I haz the power, 2015-11-16 21:24:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-16 21:25:21]

Patchset 2 (id:??) landed as
https://crrev.com/f1e91ca130c57fbabb2f990e640a6d0bc09214c2
Cr-Commit-Position: refs/heads/master@{#359921}