Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: ppapi/BUILD.gn

Issue 1434823002: Build NaCl browser tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve code review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/BUILD.gn
diff --git a/ppapi/BUILD.gn b/ppapi/BUILD.gn
index f45a2248b49c14a4a75716a1b94d845082213cd7..fa52265b1ce3c1bd39a8074f46b2a84bee18d14e 100644
--- a/ppapi/BUILD.gn
+++ b/ppapi/BUILD.gn
@@ -150,7 +150,7 @@ executable("pepper_hash_for_uma") {
]
}
-source_set("ppapi_cpp_lib") {
+static_library("ppapi_cpp_lib") {
brettw 2015/11/19 19:08:16 Why was this changed? If something depends on a st
Roland McGrath 2015/11/19 19:16:13 A comment certainly doesn't hurt. But these are s
Petr Hosek 2015/11/19 20:17:56 Comment added.
sources = ppapi_sources.cpp_source_files
sources += [
"cpp/module_embedder.h",

Powered by Google App Engine
This is Rietveld 408576698