build/config/nacl/BUILD.gn - Issue 1434823002: Build NaCl browser tests with GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/nacl/BUILD.gn

Issue 1434823002: Build NaCl browser tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve code review feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/nacl/BUILD.gn

diff --git a/build/config/nacl/BUILD.gn b/build/config/nacl/BUILD.gn

index 217494fb1ba5aeb1cbe1ddd0d16b31f56dc40dbc..53d91237a7f8b5eded759bc63251051c2070e3bb 100644

--- a/build/config/nacl/BUILD.gn

+++ b/build/config/nacl/BUILD.gn

@@ -16,6 +16,11 @@ config("nacl_defines") {

} else if (is_win) {

defines = [ "__STDC_LIMIT_MACROS=1" ]

}

+ if (current_cpu == "pnacl" && !is_nacl_nonsfi) {

+ # TODO: This be taken care of by predefines.

brettw 2015/11/19 19:08:16 I can't understand this comment. I don't know what

Petr Hosek 2015/11/19 20:17:56 Updated.

+ defines += [ "NACL_BUILD_ARCH=pnacl" ]

+ }

}

config("nexe_defines") {

« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | ppapi/BUILD.gn » ('J')