Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/BUILD.gn

Issue 1434823002: Build NaCl browser tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve code review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/nacl/BUILD.gn ('K') | « build/config/nacl/BUILD.gn ('k') | chrome/test/data/nacl/BUILD.gn » ('j') | ppapi/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index de5bd57e1a3732f4b87aeb06ccf7fbdbb539aeaf..a6b37b812b43c1728b5017ec8ec1ac99ca2fb524 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -994,7 +994,7 @@ if (!is_android) {
]
data_deps += [
- # "test/data/nacl:shared_test_files", # TODO(GYP) bug 512902
+ "//chrome/test/data/nacl",
"//ppapi/native_client:irt",
"//ppapi:ppapi_nacl_tests_all",
« build/config/nacl/BUILD.gn ('K') | « build/config/nacl/BUILD.gn ('k') | chrome/test/data/nacl/BUILD.gn » ('j') | ppapi/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698