ppapi/BUILD.gn - Issue 1434823002: Build NaCl browser tests with GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/BUILD.gn

Issue 1434823002: Build NaCl browser tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/BUILD.gn

diff --git a/ppapi/BUILD.gn b/ppapi/BUILD.gn

index 0a3f6c47722997d577fe93312039826b5f15ecf1..17d0826b248e842e5adb590da6d54c2d7ee86483 100644

--- a/ppapi/BUILD.gn

+++ b/ppapi/BUILD.gn

@@ -149,7 +149,7 @@ executable("pepper_hash_for_uma") {

]

}

-source_set("ppapi_cpp_lib") {

+static_library("ppapi_cpp_lib") {

Dirk Pranke 2015/11/11 22:19:06 why this change?

Petr Hosek 2015/11/13 22:18:33 Because some of the NaCl browser tests redefine so

Dirk Pranke 2015/11/13 23:00:57 Ew. That seems bad. Can you file a separate bug fo

Petr Hosek 2015/11/17 01:31:58 Done, see https://code.google.com/p/chromium/issue

sources = ppapi_sources.cpp_source_files

sources += [

"cpp/module_embedder.h",