Build NaCl browser tests with GN

ppapi/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 copy("copy_test_files") {
   visibility = [ ":*" ]
   sources = [
     # Keep "test_case.html.mock-http-headers" with "test_case.html".
     "tests/ppapi_nacl_tests_newlib.nmf",
     "tests/test_case.html",
@@ skipping 131 matching lines @@
   sources = [
     "tools/pepper_hash_for_uma.cc",
   ]
 
   deps = [
     "//base",
     "//build/config/sanitizers:deps",
   ]
 }
 
-source_set("ppapi_cpp_lib") {
+static_library("ppapi_cpp_lib") {

[Dirk Pranke, 2015/11/11 22:19:06]

why this change?

[Petr Hosek, 2015/11/13 22:18:33]

Because some of the NaCl browser tests redefine some symbols from this library;
that only works when this is a static library but with source set we get
multiple symbol definition errors.

[Dirk Pranke, 2015/11/13 23:00:57]

Ew. That seems bad. Can you file a separate bug for that?

[Petr Hosek, 2015/11/17 01:31:58]

Done, see https://code.google.com/p/chromium/issues/detail?id=556811

   sources = ppapi_sources.cpp_source_files
   sources += [
     "cpp/module_embedder.h",
     "cpp/ppp_entrypoints.cc",
   ]
   deps = [
     "//build/config/nacl:nacl_base",
   ]
 }
 
@@ skipping 245 matching lines @@
   group("ppapi_nacl_tests_all") {
     data_deps = [
       ":copy_test_files",
       ":nacl_tests_copy(//build/toolchain/nacl:clang_newlib_${target_cpu})",
       ":generate_nmf(//build/toolchain/nacl:glibc_${target_cpu})",
       ":generate_nmf(//build/toolchain/nacl:newlib_pnacl)",
       ":generate_nonsfi_nmf(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
     ]
   }
 }