Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: chrome/test/BUILD.gn

Issue 1434823002: Build NaCl browser tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index a795e1237d787f803eb631161d1e2cc8fcaa0d3f..ccdd6ae3216afb182179fcc7c92365cf5f78a219 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -955,7 +955,7 @@ if (!is_android) {
]
data_deps += [
- # "test/data/nacl:shared_test_files", # TODO(GYP) bug 512902
+ "//chrome/test/data/nacl",
Roland McGrath 2015/11/11 06:22:45 Don't we usually use an explicit :something here?
Dirk Pranke 2015/11/11 22:19:05 not using a ":something" defaults to ":dirname", e
Petr Hosek 2015/11/13 22:18:32 GN defaults to the name of the directory, so this
Dirk Pranke 2015/11/13 23:00:57 Don't rename the target. This is the preferred sty
"//ppapi/native_client:irt",
"//ppapi:ppapi_nacl_tests_all",

Powered by Google App Engine
This is Rietveld 408576698