Build NaCl browser tests with GN

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/chrome_tests.gni")
@@ skipping 937 matching lines @@
         sources += [
           "nacl/nacl_browsertest.cc",
           "nacl/nacl_browsertest_uma.cc",
           "nacl/nacl_browsertest_util.cc",
           "nacl/nacl_browsertest_util.h",
           "nacl/pnacl_header_test.cc",
           "nacl/pnacl_header_test.h",
         ]
 
         data_deps += [
-          # "test/data/nacl:shared_test_files",  # TODO(GYP) bug 512902
+          "//chrome/test/data/nacl",

[Roland McGrath, 2015/11/11 06:22:45]

Don't we usually use an explicit :something here?
Even if it's just "...:*"?

[Dirk Pranke, 2015/11/11 22:19:05]

not using a ":something" defaults to ":dirname", e.g.,
"//chrome/test/data/nacl:nacl".

GN does not support wildcards.

[Petr Hosek, 2015/11/13 22:18:32]

GN defaults to the name of the directory, so this line is equivalent to
"//chrome/test/data/nacl:nacl". I can rename the target if you prefer.

[Dirk Pranke, 2015/11/13 23:00:57]

Don't rename the target. This is the preferred style.

           "//ppapi/native_client:irt",
           "//ppapi:ppapi_nacl_tests_all",
 
           # "../ppapi/ppapi_nacl.gyp:ppapi_nacl_tests",  # TODO(GYP) bug 512901
           # "../ppapi/tests/extensions/extensions.gyp:ppapi_tests_extensions_background_keepalive",  # TODO(GYP) bug 512900
           # "../ppapi/tests/extensions/extensions.gyp:ppapi_tests_extensions_media_galleries",  # TODO(GYP) bug 512900
           # "../ppapi/tests/extensions/extensions.gyp:ppapi_tests_extensions_packaged_app",  # TODO(GYP) bug 512900
         ]
         if (is_chromeos) {
           sources += [ "//third_party/liblouis/nacl_wrapper/liblouis_wrapper_browsertest.cc" ]
@@ skipping 1244 matching lines @@
 
   android_library("unit_tests_java") {
     DEPRECATED_java_in_dir = "//chrome/test/android/unit_tests_apk/src"
     deps = [
       "//base:base_java",
       "//chrome/android:chrome_java",
       "//content/public/android:content_java",
     ]
   }
 }