Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 14348032: Perfrorm binding integrity check using scriptwrappable. (Closed)

Created:
7 years, 8 months ago by Tom Sepez
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nate Chapin, mkwst+watchlist_chromium.org, abarth-chromium
Visibility:
Public.

Description

This change turns on the generic binding integrity checks across all platforms that has been implemented in the prior patches. BUG=226633 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148942 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149984

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add binding test results. #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : use RELEASE_ASSERT #

Patch Set 6 : Patch set for relanding following revert. #

Patch Set 7 : roll in fix from https://codereview.chromium.org/14520011/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomNamedGetter.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObj.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Tom Sepez
Adam, please take a look. This is complicated by the redness of the try bots ...
7 years, 8 months ago (2013-04-23 18:37:58 UTC) #1
haraken
LGTM. abarth will take another look. You need to update run-bindings-tests results.
7 years, 8 months ago (2013-04-23 19:02:32 UTC) #2
Tom Sepez
Yep. Seems like the bots don't run em. Thanks.
7 years, 8 months ago (2013-04-23 19:19:58 UTC) #3
abarth-chromium
LGTM!! https://codereview.chromium.org/14348032/diff/16001/Source/bindings/scripts/CodeGeneratorV8.pm File Source/bindings/scripts/CodeGeneratorV8.pm (right): https://codereview.chromium.org/14348032/diff/16001/Source/bindings/scripts/CodeGeneratorV8.pm#newcode587 Source/bindings/scripts/CodeGeneratorV8.pm:587: CRASH(); Should we be using RELEASE_ASSERT? cevans seemed ...
7 years, 8 months ago (2013-04-23 21:09:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/14348032/20001
7 years, 8 months ago (2013-04-23 21:53:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=3066
7 years, 8 months ago (2013-04-23 22:41:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/14348032/20001
7 years, 8 months ago (2013-04-23 22:44:15 UTC) #7
commit-bot: I haz the power
Change committed as 148942
7 years, 8 months ago (2013-04-23 23:26:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/14348032/30001
7 years, 7 months ago (2013-05-08 20:35:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/14348032/35001
7 years, 7 months ago (2013-05-08 20:52:38 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 22:20:41 UTC) #11
Message was sent while issue was closed.
Change committed as 149984

Powered by Google App Engine
This is Rietveld 408576698