Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14348032: Perfrorm binding integrity check using scriptwrappable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: roll in fix from https://codereview.chromium.org/14520011/ Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestActiveDOMObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 905 matching lines...) Expand 10 before | Expand all | Expand 10 after
916 916
917 v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creation Context, v8::Isolate*); 917 v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creation Context, v8::Isolate*);
918 END 918 END
919 } else { 919 } else {
920 $header{nameSpaceWebCore}->add(<<END); 920 $header{nameSpaceWebCore}->add(<<END);
921 921
922 inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate) 922 inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate)
923 { 923 {
924 ASSERT(impl); 924 ASSERT(impl);
925 ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty()); 925 ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
926 if (ScriptWrappable::wrapperCanBeStoredInObject(impl)) {
927 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl);
928 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have
929 // the same object de-ref functions, though, so use that as the basis of the check.
930 RELEASE_ASSERT(actualInfo->derefObjectFunction == ${v8InterfaceName}::in fo.derefObjectFunction);
931 }
926 return ${returningCreatedWrapperOpening}$createWrapperCall(impl, creationCon text, isolate)${returningCreatedWrapperClosing}; 932 return ${returningCreatedWrapperOpening}$createWrapperCall(impl, creationCon text, isolate)${returningCreatedWrapperClosing};
927 } 933 }
928 END 934 END
929 } 935 }
930 936
931 $header{nameSpaceWebCore}->add(<<END); 937 $header{nameSpaceWebCore}->add(<<END);
932 938
933 inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Handle<v8::Object> cr eationContext, v8::Isolate* isolate) 939 inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Handle<v8::Object> cr eationContext, v8::Isolate* isolate)
934 { 940 {
935 if (UNLIKELY(!impl)) 941 if (UNLIKELY(!impl))
(...skipping 4749 matching lines...) Expand 10 before | Expand all | Expand 10 after
5685 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 5691 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
5686 $found = 1; 5692 $found = 1;
5687 } 5693 }
5688 return 1 if $found; 5694 return 1 if $found;
5689 }, 0); 5695 }, 0);
5690 5696
5691 return $found; 5697 return $found;
5692 } 5698 }
5693 5699
5694 1; 5700 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestActiveDOMObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698