[SPDY] Close SPDY sessions on session flow control errors

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index fe3584829c5dcfb7b2f0b75f99e40779b77a58c0..f7662a78608e95573606c695c2767c1ca9b8e93a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -1957,6 +1957,14 @@ other types of suffix sets.
 
 <histogram name="Net.SpdySessionErrorDetails" enum="SpdyProtocolErrorDetails"
     units="count">
+  <summary>
+    The type of SPDY Protocol error encountered. Replaced by
+    SpdySessionErrorDetails2 on 2013-04-19.

[jar (doing other things), 2013/04/19 21:26:19]

If you use the <obsolete> tag in these, then the won't clutter the dashboard
(unless you click the box to get the obsolete stuff).

[akalin, 2013/04/19 21:34:31]

Done.

+  </summary>
+</histogram>
+
+<histogram name="Net.SpdySessionErrorDetails2" enum="SpdyProtocolErrorDetails2"
+    units="count">
   <summary>The type of SPDY Protocol error encountered.</summary>
 </histogram>
 
@@ -1964,6 +1972,14 @@ other types of suffix sets.
     enum="SpdyProtocolErrorDetails" units="count">
   <summary>
     The type of SPDY Protocol error encountered when talking to a google.com
+    server. Replaced by SpdySessionErrorDetails_Google2 on 2013-04-19.
+  </summary>
+</histogram>
+
+<histogram name="Net.SpdySessionErrorDetails_Google2"
+    enum="SpdyProtocolErrorDetails2" units="count">
+  <summary>
+    The type of SPDY Protocol error encountered when talking to a google.com
     server.
   </summary>
 </histogram>
@@ -4761,6 +4777,7 @@ other types of suffix sets.
   <int value="803" label="DNS_TIMED_OUT"/>
   <int value="804" label="DNS_CACHE_MISS"/>
   <int value="805" label="DNS_SEARCH_EMPTY"/>
+  <int value="806" label="DNS_SORT_ERROR"/>
 </enum>
 
 <enum name="NetPreconnectUtilization" type="int">
@@ -5069,6 +5086,8 @@ other types of suffix sets.
   <int value="1" label="match"/>
 </enum>
 
+<!-- Replaced by SpdyProtocolErrorDetails2 on 2013-04-19. -->
+
 <enum name="SpdyProtocolErrorDetails" type="int">
   <int value="0" label="No error"/>
   <int value="1" label="Invalid Control Frame"/>
@@ -5079,6 +5098,9 @@ other types of suffix sets.
   <int value="6" label="Compress Failure"/>
   <int value="7" label="Credential Frame Corrupt"/>
   <int value="8" label="Invalid Data Frame Flags"/>
+<!-- r181910 added an enum value here, so don't trust the counts for
+       the values below for Chrome builds after that revision. -->

[jar (doing other things), 2013/04/19 23:12:38]

<ugh>  No one will notice the comment when looking at the bogus data.

Perhaps you should edit the labels below.  Maybe add the word "conflated" to
each label <sigh>.  

Maybe you should add a "warning" to the histograms that use this enum. That
might be easier!  Up front, in all caps, in addition to <obsolete>ing them.

+
   <int value="9" label="Invalid Status Code"/>
   <int value="10" label="Protocol Error"/>
   <int value="11" label="Invalid Stream"/>
@@ -5099,6 +5121,45 @@ other types of suffix sets.
   <int value="26" label="Num Spdy Protocol Error Details"/>
 </enum>
 
+<enum name="SpdyProtocolErrorDetails2" type="int">
+<!-- SpdyFramer::SpdyErrors -->
+
+  <int value="0" label="No error"/>
+  <int value="1" label="Invalid Control Frame"/>
+  <int value="2" label="Control Frame Payload Too Large"/>
+  <int value="3" label="Zlib Init Failure"/>
+  <int value="4" label="Unsupported Version"/>
+  <int value="5" label="Decompress Failure"/>
+  <int value="6" label="Compress Failure"/>
+  <int value="7" label="Credential Frame Corrupt"/>
+  <int value="8" label="Invalid Data Frame Flags"/>
+  <int value="9" label="Invalid Control Frame Flags"/>
+<!-- SpdyRstStreamStatus -->
+
+  <int value="10" label="(Unused)"/>
+  <int value="11" label="Protocol Error"/>
+  <int value="12" label="Invalid Stream"/>
+  <int value="13" label="Refused Stream"/>
+  <int value="14" label="Unsupported Version"/>
+  <int value="15" label="Cancel"/>
+  <int value="16" label="Internal Error"/>
+  <int value="17" label="Flow Control Error"/>
+  <int value="18" label="Stream In Use"/>
+  <int value="19" label="Stream Already Closed"/>
+  <int value="20" label="Invalid Credentials"/>
+  <int value="21" label="Frame Too Large"/>
+<!-- SpdySession errors -->
+
+  <int value="22" label="Unexpected Ping"/>
+  <int value="23" label="Rst Stream For Non Active Stream"/>
+  <int value="24" label="Spdy Compression Failure"/>
+  <int value="25" label="Request For Secure Content Over Insecure Session"/>
+  <int value="26" label="Syn Reply Not Received"/>
+  <int value="27" label="Invalid Window Update Size"/>
+  <int value="28" label="Receive Window Size Violation"/>
+  <int value="29" label="(Unused)"/>
+</enum>
+
 <enum name="SpdySessionGet" type="int">
   <int value="0" label="created new"/>
   <int value="1" label="found existing"/>