[SPDY] Close SPDY sessions on session flow control errors

tools/metrics/histograms/histograms.xml

 <!--
 Copyright 2013 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <!--
 This file is used to generate a comprehensive list of Chrome histograms along
 with a detailed description for each histogram.
 
@@ skipping 1939 matching lines @@
 <histogram name="Net.SpdyRecvBytes" units="bytes">
   <summary>The number of bytes recevied per stream.</summary>
 </histogram>
 
 <histogram name="Net.SpdySendBytes" units="bytes">
   <summary>The number of bytes sent per stream.</summary>
 </histogram>
 
 <histogram name="Net.SpdySessionErrorDetails" enum="SpdyProtocolErrorDetails"
     units="count">
+  <summary>
+    The type of SPDY Protocol error encountered. Replaced by
+    SpdySessionErrorDetails2 on 2013-04-19.

[jar (doing other things), 2013/04/19 21:26:19]

If you use the <obsolete> tag in these, then the won't clutter the dashboard
(unless you click the box to get the obsolete stuff).

[akalin, 2013/04/19 21:34:31]

Done.

+  </summary>
+</histogram>
+
+<histogram name="Net.SpdySessionErrorDetails2" enum="SpdyProtocolErrorDetails2"
+    units="count">
   <summary>The type of SPDY Protocol error encountered.</summary>
 </histogram>
 
 <histogram name="Net.SpdySessionErrorDetails_Google"
     enum="SpdyProtocolErrorDetails" units="count">
   <summary>
     The type of SPDY Protocol error encountered when talking to a google.com
+    server. Replaced by SpdySessionErrorDetails_Google2 on 2013-04-19.
+  </summary>
+</histogram>
+
+<histogram name="Net.SpdySessionErrorDetails_Google2"
+    enum="SpdyProtocolErrorDetails2" units="count">
+  <summary>
+    The type of SPDY Protocol error encountered when talking to a google.com
     server.
   </summary>
 </histogram>
 
 <histogram name="Net.SpdySessionGet" enum="SpdySessionGet" units="count">
   <summary>The type of SPDY Session used when looking up a session.</summary>
 </histogram>
 
 <histogram name="Net.SpdySessionGetPeerAddressNotConnected"
     enum="BooleanSuccess">
@@ skipping 2777 matching lines @@
   <int value="709" label="PKCS12_IMPORT_UNSUPPORTED"/>
   <int value="710" label="KEY_GENERATION_FAILED"/>
   <int value="711" label="ORIGIN_BOUND_CERT_GENERATION_FAILED"/>
   <int value="712" label="PRIVATE_KEY_EXPORT_FAILED"/>
   <int value="800" label="DNS_MALFORMED_RESPONSE"/>
   <int value="801" label="DNS_SERVER_REQUIRES_TCP"/>
   <int value="802" label="DNS_SERVER_FAILED"/>
   <int value="803" label="DNS_TIMED_OUT"/>
   <int value="804" label="DNS_CACHE_MISS"/>
   <int value="805" label="DNS_SEARCH_EMPTY"/>
+  <int value="806" label="DNS_SORT_ERROR"/>
 </enum>
 
 <enum name="NetPreconnectUtilization" type="int">
   <int value="0" label="non-speculative, never connected"/>
   <int value="1" label="non-speculative, never used"/>
   <int value="2" label="non-speculative and used"/>
   <int value="3" label="omnibox never connected"/>
   <int value="4" label="omnibox never used"/>
   <int value="5" label="omnibox and used"/>
   <int value="6" label="subresource never connected"/>
@@ skipping 288 matching lines @@
   <int value="0" label="unknown"/>
   <int value="1" label="ws"/>
   <int value="2" label="wss"/>
 </enum>
 
 <enum name="SpdyIPPoolDomainMatch" type="int">
   <int value="0" label="mismatch"/>
   <int value="1" label="match"/>
 </enum>
 
+<!-- Replaced by SpdyProtocolErrorDetails2 on 2013-04-19. -->
+
 <enum name="SpdyProtocolErrorDetails" type="int">
   <int value="0" label="No error"/>
   <int value="1" label="Invalid Control Frame"/>
   <int value="2" label="Control Frame Payload Too Large"/>
   <int value="3" label="Zlib Init Failure"/>
   <int value="4" label="Unsupported Version"/>
   <int value="5" label="Decompress Failure"/>
   <int value="6" label="Compress Failure"/>
   <int value="7" label="Credential Frame Corrupt"/>
   <int value="8" label="Invalid Data Frame Flags"/>
+<!-- r181910 added an enum value here, so don't trust the counts for
+       the values below for Chrome builds after that revision. -->

[jar (doing other things), 2013/04/19 23:12:38]

<ugh>  No one will notice the comment when looking at the bogus data.

Perhaps you should edit the labels below.  Maybe add the word "conflated" to
each label <sigh>.  

Maybe you should add a "warning" to the histograms that use this enum. That
might be easier!  Up front, in all caps, in addition to <obsolete>ing them.

+
   <int value="9" label="Invalid Status Code"/>
   <int value="10" label="Protocol Error"/>
   <int value="11" label="Invalid Stream"/>
   <int value="12" label="Refused Stream"/>
   <int value="13" label="Unsupported Version"/>
   <int value="14" label="Cancel"/>
   <int value="15" label="Internal Error"/>
   <int value="16" label="Flow Control Error"/>
   <int value="17" label="Stream In Use"/>
   <int value="18" label="Stream Already Closed"/>
   <int value="19" label="Invalid Credentials"/>
   <int value="20" label="Frame Too Large"/>
   <int value="21" label="Unexpected Ping"/>
   <int value="22" label="Rst Stream For Non Active Stream"/>
   <int value="23" label="Spdy Compression Failure"/>
   <int value="24" label="Request For Secure Content Over Insecure Session"/>
   <int value="25" label="Protocol Error Syn Reply Not Received"/>
   <int value="26" label="Num Spdy Protocol Error Details"/>
 </enum>
 
+<enum name="SpdyProtocolErrorDetails2" type="int">
+<!-- SpdyFramer::SpdyErrors -->
+
+  <int value="0" label="No error"/>
+  <int value="1" label="Invalid Control Frame"/>
+  <int value="2" label="Control Frame Payload Too Large"/>
+  <int value="3" label="Zlib Init Failure"/>
+  <int value="4" label="Unsupported Version"/>
+  <int value="5" label="Decompress Failure"/>
+  <int value="6" label="Compress Failure"/>
+  <int value="7" label="Credential Frame Corrupt"/>
+  <int value="8" label="Invalid Data Frame Flags"/>
+  <int value="9" label="Invalid Control Frame Flags"/>
+<!-- SpdyRstStreamStatus -->
+
+  <int value="10" label="(Unused)"/>
+  <int value="11" label="Protocol Error"/>
+  <int value="12" label="Invalid Stream"/>
+  <int value="13" label="Refused Stream"/>
+  <int value="14" label="Unsupported Version"/>
+  <int value="15" label="Cancel"/>
+  <int value="16" label="Internal Error"/>
+  <int value="17" label="Flow Control Error"/>
+  <int value="18" label="Stream In Use"/>
+  <int value="19" label="Stream Already Closed"/>
+  <int value="20" label="Invalid Credentials"/>
+  <int value="21" label="Frame Too Large"/>
+<!-- SpdySession errors -->
+
+  <int value="22" label="Unexpected Ping"/>
+  <int value="23" label="Rst Stream For Non Active Stream"/>
+  <int value="24" label="Spdy Compression Failure"/>
+  <int value="25" label="Request For Secure Content Over Insecure Session"/>
+  <int value="26" label="Syn Reply Not Received"/>
+  <int value="27" label="Invalid Window Update Size"/>
+  <int value="28" label="Receive Window Size Violation"/>
+  <int value="29" label="(Unused)"/>
+</enum>
+
 <enum name="SpdySessionGet" type="int">
   <int value="0" label="created new"/>
   <int value="1" label="found existing"/>
   <int value="2" label="found existing from IP Pool"/>
   <int value="3" label="imported from socket"/>
 </enum>
 
 <enum name="SpdySettingsReceived" type="int">
   <int value="0" label="not received"/>
   <int value="1" label="received"/>
@@ skipping 488 matching lines @@
 <fieldtrial name="SSLResumption">
   <group name="Resume_Handshake" label="Session Resumption"/>
   <group name="Full_Handshake" label="Full"/>
   <affected-histogram name="Net.SSL_Connection_Latency"/>
   <affected-histogram name="Net.SSL_Connection_Latency_Google"/>
 </fieldtrial>
 
 </fieldtrials>
 
 </histogram-configuration>