Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1434693008: Revert changes introduced in http://crrev.com/1367953002. (Closed)

Created:
5 years, 1 month ago by epertoso
Modified:
5 years, 1 month ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert changes introduced in http://crrev.com/1367953002. This CL is in preparation for the API change introduced in http://crrev.com/1407313004. BUG= Committed: https://crrev.com/56c7a053e9f88a0c0a4ff29d737034724e6509c0 Cr-Commit-Position: refs/heads/master@{#31930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -66 lines) Patch
M include/v8.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/api-natives.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/api-natives.cc View 3 chunks +13 lines, -37 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
epertoso
5 years, 1 month ago (2015-11-10 20:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434693008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434693008/1
5 years, 1 month ago (2015-11-10 20:39:00 UTC) #5
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
5 years, 1 month ago (2015-11-10 20:39:01 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434693008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434693008/1
5 years, 1 month ago (2015-11-10 20:40:10 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-10 20:40:14 UTC) #11
vogelheim
lgtm
5 years, 1 month ago (2015-11-10 20:45:02 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 20:57:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434693008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434693008/1
5 years, 1 month ago (2015-11-10 20:58:52 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 21:00:04 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 21:00:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56c7a053e9f88a0c0a4ff29d737034724e6509c0
Cr-Commit-Position: refs/heads/master@{#31930}

Powered by Google App Engine
This is Rietveld 408576698