Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/api.cc

Issue 1434693008: Revert changes introduced in http://crrev.com/1367953002. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/api-natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 0c019a73848744c779db8cde72722c4289ad8051..5d4c9c0c415ac558747dfa55b25b19a02c9187b4 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -957,25 +957,6 @@ void Template::SetAccessorProperty(
}
-#ifdef V8_JS_ACCESSORS
-void Template::SetAccessorProperty(v8::Local<v8::Name> name,
- v8::Local<Function> getter,
- v8::Local<Function> setter,
- v8::PropertyAttribute attribute) {
- auto templ = Utils::OpenHandle(this);
- auto isolate = templ->GetIsolate();
- ENTER_V8(isolate);
- DCHECK(!name.IsEmpty());
- DCHECK(!getter.IsEmpty() || !setter.IsEmpty());
- i::HandleScope scope(isolate);
- i::ApiNatives::AddAccessorProperty(
- isolate, templ, Utils::OpenHandle(*name),
- Utils::OpenHandle(*getter, true), Utils::OpenHandle(*setter, true),
- static_cast<PropertyAttributes>(attribute));
-}
-#endif // V8_JS_ACCESSORS
-
-
// --- F u n c t i o n T e m p l a t e ---
static void InitializeFunctionTemplate(
i::Handle<i::FunctionTemplateInfo> info) {
« no previous file with comments | « include/v8.h ('k') | src/api-natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698