Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434633004: Remove const std::string return by std::string (Closed)

Created:
5 years, 1 month ago by tanay.c
Modified:
5 years, 1 month ago
Reviewers:
pdr., Mike West
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove const std::string return by std::string BUG=393155 Committed: https://crrev.com/3c763962e48e27a991cc118e7404325bf71d2b67 Cr-Commit-Position: refs/heads/master@{#359056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/browsing_data/cookies_tree_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tanay.c
PTAL
5 years, 1 month ago (2015-11-10 09:05:21 UTC) #4
Mike West
LGTM.
5 years, 1 month ago (2015-11-10 16:51:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434633004/1
5 years, 1 month ago (2015-11-11 04:18:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 05:24:51 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c763962e48e27a991cc118e7404325bf71d2b67 Cr-Commit-Position: refs/heads/master@{#359056}
5 years, 1 month ago (2015-11-11 05:25:52 UTC) #9
vabr (Chromium)
5 years, 1 month ago (2015-11-11 09:21:33 UTC) #10
Message was sent while issue was closed. 
Drive-by: Please consider http://crbug.com/393155#c4 in the future, dropping the
const might actually not make things better.

Powered by Google App Engine
This is Rietveld 408576698