Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: chrome/browser/browsing_data/cookies_tree_model.cc

Issue 1434633004: Remove const std::string return by std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browsing_data/cookies_tree_model.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/cookies_tree_model.h" 5 #include "chrome/browser/browsing_data/cookies_tree_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <functional> 8 #include <functional>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 623 matching lines...) Expand 10 before | Expand all | Expand 10 after
634 : url.host()); 634 : url.host());
635 } 635 }
636 636
637 CookieTreeHostNode::CookieTreeHostNode(const GURL& url) 637 CookieTreeHostNode::CookieTreeHostNode(const GURL& url)
638 : CookieTreeNode(TitleForUrl(url)), 638 : CookieTreeNode(TitleForUrl(url)),
639 url_(url), 639 url_(url),
640 canonicalized_host_(CanonicalizeHost(url)) {} 640 canonicalized_host_(CanonicalizeHost(url)) {}
641 641
642 CookieTreeHostNode::~CookieTreeHostNode() {} 642 CookieTreeHostNode::~CookieTreeHostNode() {}
643 643
644 const std::string CookieTreeHostNode::GetHost() const { 644 std::string CookieTreeHostNode::GetHost() const {
645 const std::string file_origin_node_name( 645 const std::string file_origin_node_name(
646 std::string(url::kFileScheme) + url::kStandardSchemeSeparator); 646 std::string(url::kFileScheme) + url::kStandardSchemeSeparator);
647 return url_.SchemeIsFile() ? file_origin_node_name : url_.host(); 647 return url_.SchemeIsFile() ? file_origin_node_name : url_.host();
648 } 648 }
649 649
650 CookieTreeNode::DetailedInfo CookieTreeHostNode::GetDetailedInfo() const { 650 CookieTreeNode::DetailedInfo CookieTreeHostNode::GetDetailedInfo() const {
651 return DetailedInfo().InitHost(); 651 return DetailedInfo().InitHost();
652 } 652 }
653 653
654 CookieTreeCookiesNode* CookieTreeHostNode::GetOrCreateCookiesNode() { 654 CookieTreeCookiesNode* CookieTreeHostNode::GetOrCreateCookiesNode() {
(...skipping 888 matching lines...) Expand 10 before | Expand all | Expand 10 after
1543 void CookiesTreeModel::MaybeNotifyBatchesEnded() { 1543 void CookiesTreeModel::MaybeNotifyBatchesEnded() {
1544 // Only notify the observers if this is the outermost call to EndBatch() if 1544 // Only notify the observers if this is the outermost call to EndBatch() if
1545 // called in a nested manner. 1545 // called in a nested manner.
1546 if (batches_ended_ == batches_started_ && 1546 if (batches_ended_ == batches_started_ &&
1547 batches_seen_ == batches_expected_) { 1547 batches_seen_ == batches_expected_) {
1548 FOR_EACH_OBSERVER(Observer, 1548 FOR_EACH_OBSERVER(Observer,
1549 cookies_observer_list_, 1549 cookies_observer_list_,
1550 TreeModelEndBatch(this)); 1550 TreeModelEndBatch(this));
1551 } 1551 }
1552 } 1552 }
OLDNEW
« no previous file with comments | « chrome/browser/browsing_data/cookies_tree_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698