Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143463009: Add policy that forces SAML users to log in online periodically (Closed)

Created:
6 years, 11 months ago by bartfab (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, jar (doing other things), Ilya Sherman, joaodasilva+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add policy that forces SAML users to log in online periodically This CL adds a user policy which limits the time for which a user authenticated via SAML can log in offline. When the limit is reached, the user is required to go through the online flow on next login. BUG=332081 TEST=Full unit test and browser test coverage Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247984

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits addressed. #

Total comments: 12

Patch Set 3 : Comments addressed. #

Patch Set 4 : Rebased. #

Patch Set 5 : Fixed compilation with clang. #

Patch Set 6 : Fix compilation with clang. #

Patch Set 7 : Rebased. #

Patch Set 8 : Speculative fix for PolicyPrefIndicatorTest.CheckPolicyIndicators/3. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1164 lines, -512 lines) Patch
M chrome/browser/chromeos/login/login_utils.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 2 3 16 chunks +167 lines, -20 lines 0 comments Download
A chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.h View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc View 1 2 1 chunk +151 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_factory.h View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_factory.cc View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc View 1 2 3 4 5 1 chunk +582 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/login/saml_browsertest.cc View 1 2 3 1 chunk +0 lines, -489 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 3 4 5 6 2 chunks +25 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
bartfab (slow)
Hi Nikita, Could you please review chrome/browser/chromeos/login/*? Hi Daniel, Could you please review the policy ...
6 years, 11 months ago (2014-01-22 17:42:34 UTC) #1
Alexei Svitkine (slow)
histograms.xml lgtm
6 years, 11 months ago (2014-01-22 18:07:30 UTC) #2
dconnelly
lgtm https://codereview.chromium.org/143463009/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/143463009/diff/1/components/policy/resources/policy_templates.json#newcode3452 components/policy/resources/policy_templates.json:3452: Leaving this policy not set will make <ph ...
6 years, 11 months ago (2014-01-23 08:40:55 UTC) #3
Mattias Nissler (ping if slow)
chrome/common/pref_names.* LGTM https://codereview.chromium.org/143463009/diff/1/chrome/browser/chromeos/login/saml_offline_signin_limiter.cc File chrome/browser/chromeos/login/saml_offline_signin_limiter.cc (right): https://codereview.chromium.org/143463009/diff/1/chrome/browser/chromeos/login/saml_offline_signin_limiter.cc#newcode28 chrome/browser/chromeos/login/saml_offline_signin_limiter.cc:28: 1209600, // 14 days, expressed in seconds. ...
6 years, 11 months ago (2014-01-23 08:49:14 UTC) #4
bartfab (slow)
https://codereview.chromium.org/143463009/diff/1/chrome/browser/chromeos/login/saml_offline_signin_limiter.cc File chrome/browser/chromeos/login/saml_offline_signin_limiter.cc (right): https://codereview.chromium.org/143463009/diff/1/chrome/browser/chromeos/login/saml_offline_signin_limiter.cc#newcode28 chrome/browser/chromeos/login/saml_offline_signin_limiter.cc:28: 1209600, // 14 days, expressed in seconds. On 2014/01/23 ...
6 years, 11 months ago (2014-01-23 09:47:22 UTC) #5
Nikita (slow)
Please place new files under login/saml https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/login_utils.cc#newcode584 chrome/browser/chromeos/login/login_utils.cc:584: if (saml_offline_signin_limiter) When ...
6 years, 11 months ago (2014-01-23 17:31:14 UTC) #6
Nikita (slow)
https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/saml_browsertest.cc File chrome/browser/chromeos/login/saml_browsertest.cc (right): https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/saml_browsertest.cc#newcode218 chrome/browser/chromeos/login/saml_browsertest.cc:218: command_line->AppendSwitchASCII("remote-debugging-port", "9999"); nit: Debug change? https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/saml_browsertest.cc#newcode545 chrome/browser/chromeos/login/saml_browsertest.cc:545: UserManager::Get()->SaveUserOAuthStatus(kNonSAMLUserEmail, nit: ...
6 years, 11 months ago (2014-01-23 17:50:08 UTC) #7
bartfab (slow)
https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/143463009/diff/120001/chrome/browser/chromeos/login/login_utils.cc#newcode584 chrome/browser/chromeos/login/login_utils.cc:584: if (saml_offline_signin_limiter) On 2014/01/23 17:31:15, Nikita Kostylev wrote: > ...
6 years, 11 months ago (2014-01-24 12:56:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/230001
6 years, 11 months ago (2014-01-26 08:05:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=46509
6 years, 11 months ago (2014-01-26 08:24:41 UTC) #10
Nikita (slow)
lgtm
6 years, 11 months ago (2014-01-26 17:43:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/230001
6 years, 11 months ago (2014-01-27 10:02:21 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=68793
6 years, 11 months ago (2014-01-27 11:34:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/660001
6 years, 11 months ago (2014-01-27 12:18:06 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=252126
6 years, 11 months ago (2014-01-27 13:36:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/660001
6 years, 11 months ago (2014-01-27 13:56:23 UTC) #16
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=68816
6 years, 11 months ago (2014-01-27 15:36:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/960001
6 years, 11 months ago (2014-01-27 17:01:34 UTC) #18
commit-bot: I haz the power
Failed to apply patch for components/policy/resources/policy_templates.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-27 22:39:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/860003
6 years, 10 months ago (2014-01-28 18:22:41 UTC) #20
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217358
6 years, 10 months ago (2014-01-28 20:53:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/860003
6 years, 10 months ago (2014-01-28 20:57:37 UTC) #22
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=195671
6 years, 10 months ago (2014-01-29 00:35:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/860003
6 years, 10 months ago (2014-01-29 10:53:14 UTC) #24
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=195919
6 years, 10 months ago (2014-01-29 15:58:52 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/143463009/1130001
6 years, 10 months ago (2014-01-30 15:08:00 UTC) #26
commit-bot: I haz the power
Change committed as 247984
6 years, 10 months ago (2014-01-30 17:50:21 UTC) #27
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 17:50:29 UTC) #28
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698