Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 143463002: Apply flood-opacity for feDropShadow (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Apply flood-opacity for feDropShadow FEDropShadow::m_shadowOpacity was set but never used. Also fix a typo nearby in FEDropShadow::createImageFilter (stdY should be scaled with the vertical scale factor - as in FEDropShadow::applySoftware.) TEST=svg/filters/feDropShadow-flood-opacity-*.svg BUG=336222 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165445

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/svg/filters/feDropShadow-flood-opacity-1.svg View 1 chunk +10 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/feDropShadow-flood-opacity-1-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/filters/feDropShadow-flood-opacity-2.svg View 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/feDropShadow-flood-opacity-2-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/platform/graphics/filters/FEDropShadow.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 11 months ago (2014-01-20 17:16:37 UTC) #1
Stephen White
LGTM. Thanks for the patch!
6 years, 11 months ago (2014-01-20 17:48:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/143463002/1
6 years, 11 months ago (2014-01-21 08:04:02 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-21 08:04:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/143463002/80001
6 years, 11 months ago (2014-01-21 08:26:01 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 10:06:24 UTC) #6
Message was sent while issue was closed.
Change committed as 165445

Powered by Google App Engine
This is Rietveld 408576698