Source/core/dom/shadow/ShadowRoot.idl - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.idl

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Null HTMLCollection handling Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('K') | « Source/core/dom/TagNodeList.cpp ('k') | Source/core/fetch/FontResource.cpp » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/shadow/ShadowRoot.idl

diff --git a/Source/core/dom/shadow/ShadowRoot.idl b/Source/core/dom/shadow/ShadowRoot.idl

index 5173b2bb5e4a92374e3185a4c5cf4f6155aa3844..4a74d5a24fe74e787a51bc7966c58075a4327a3f 100644

--- a/Source/core/dom/shadow/ShadowRoot.idl

+++ b/Source/core/dom/shadow/ShadowRoot.idl

@@ -36,10 +36,10 @@

[RaisesException] Node cloneNode([Default=Undefined] optional boolean deep);

Selection getSelection();

Element getElementById([Default=Undefined] optional DOMString elementId);

- NodeList getElementsByClassName([Default=Undefined] optional DOMString className);

- NodeList getElementsByTagName([Default=Undefined] optional DOMString tagName);

- NodeList getElementsByTagNameNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,

- [Default=Undefined] optional DOMString localName);

+ HTMLCollection getElementsByClassName([Default=Undefined] optional DOMString className);

+ HTMLCollection getElementsByTagName([Default=Undefined] optional DOMString tagName);

+ HTMLCollection getElementsByTagNameNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,

+ [Default=Undefined] optional DOMString localName);

Element elementFromPoint([Default=Undefined] optional long x,

[Default=Undefined] optional long y);