Source/core/dom/ContainerNode.h - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.h

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Null HTMLCollection handling Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('K') | « Source/core/dom/ClassNodeList.cpp ('k') | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ContainerNode.h

diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h

index 77080b8dd2a370eec022f55c1155be5ae6344a7b..1ba2f8a5363f822117714952f4e9221bb6005c81 100644

--- a/Source/core/dom/ContainerNode.h

+++ b/Source/core/dom/ContainerNode.h

@@ -104,10 +104,10 @@ public:

void removeChild(Node* child, ExceptionState& = ASSERT_NO_EXCEPTION);

void appendChild(PassRefPtr<Node> newChild, ExceptionState& = ASSERT_NO_EXCEPTION);

- PassRefPtr<NodeList> getElementsByTagName(const AtomicString&);

- PassRefPtr<NodeList> getElementsByTagNameNS(const AtomicString& namespaceURI, const AtomicString& localName);

+ PassRefPtr<HTMLCollection> getElementsByTagName(const AtomicString&);

+ PassRefPtr<HTMLCollection> getElementsByTagNameNS(const AtomicString& namespaceURI, const AtomicString& localName);

PassRefPtr<NodeList> getElementsByName(const AtomicString& elementName);

- PassRefPtr<NodeList> getElementsByClassName(const AtomicString& classNames);

+ PassRefPtr<HTMLCollection> getElementsByClassName(const AtomicString& classNames);

PassRefPtr<RadioNodeList> radioNodeList(const AtomicString&, bool onlyMatchImgElements = false);

// These methods are only used during parsing.