LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Unified Diff: LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Null HTMLCollection handling Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/js/constructor-expected.txt ('k') | LayoutTests/fast/js/script-tests/constructor.js » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

diff --git a/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt b/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

index 8a98c734335444c87e3a222de538de95c4f56f68..7692b5aa7d9a7f41f756e1a259dc27a43c69eb23 100644

--- a/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

+++ b/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

@@ -142,7 +142,7 @@ FAIL Object.getOwnPropertyDescriptor(global, 0).configurable should be false. Th

PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').value is 1

PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').hasOwnProperty('get') is false

PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').hasOwnProperty('set') is false

-FAIL Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable should be true. Was false.

+PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable is true

arv (Not doing code reviews) 2014/01/29 04:45:48 length should not be enumerable.

Inactive 2014/01/29 14:08:14 I see, is this documented somewhere? http://dom.sp

Inactive 2014/01/29 16:21:34 Done. I confirmed that FF26 and IE11 also mark HTM

Inactive 2014/01/29 21:17:36 Not strictly related to this CL so I filed https:/

FAIL Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').configurable should be false. Was true.

PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).value is document.getElementsByTagName('div')[0]

PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).hasOwnProperty('get') is false

@@ -157,7 +157,7 @@ FAIL Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0)

PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').value is document.getElementsByClassName('pass').length

PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').hasOwnProperty('get') is false

PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').hasOwnProperty('set') is false

-FAIL Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').enumerable should be true. Was false.

+PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').enumerable is true

FAIL Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').configurable should be false. Was true.

PASS Object.getOwnPropertyDescriptor(select, 'length').value is select.length

PASS Object.getOwnPropertyDescriptor(select, 'length').hasOwnProperty('get') is false

« no previous file with comments | « LayoutTests/fast/js/constructor-expected.txt ('k') | LayoutTests/fast/js/script-tests/constructor.js » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')