Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection instead of a NodeList, as per the specification: http://dom.spec.whatwg.org/#document http://dom.spec.whatwg.org/#element This behavior is consistent with Firefox 26 and IE 11. R=arv, haraken, tkent BUG=235008 BUG=339442 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166263

Patch Set 1 #

Patch Set 2 : Handling of null HTMLCollection #

Patch Set 3 : Null HTMLCollection handling #

Total comments: 7

Patch Set 4 : Make HTMLCollection.length not enumerable #

Patch Set 5 : Rebaseline inspector test #

Patch Set 6 : Rebase #

Patch Set 7 : Add missing include #

Patch Set 8 : Keep HTMLCollection.length change out of this CL #

Total comments: 2

Patch Set 9 : Add BLINK_EXPORT #

Patch Set 10 : Fix !m_adoptionIsRequired assertion hit #

Patch Set 11 : Rebase #

Patch Set 12 : Rebase #

Patch Set 13 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -481 lines) Patch
M LayoutTests/fast/dom/getElementsByClassName/dumpNodeList.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/domListEnumeration.js View 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-classes.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-classes-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/constructor-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt View 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/script-tests/constructor.js View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/dom/ClassCollection.h View 1 chunk +15 lines, -18 lines 0 comments Download
A + Source/core/dom/ClassCollection.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
D Source/core/dom/ClassNodeList.h View 1 chunk +0 lines, -78 lines 0 comments Download
D Source/core/dom/ClassNodeList.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Document.idl View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/NodeRareData.h View 8 chunks +13 lines, -13 lines 0 comments Download
A + Source/core/dom/TagCollection.h View 2 chunks +24 lines, -26 lines 0 comments Download
A + Source/core/dom/TagCollection.cpp View 3 chunks +7 lines, -12 lines 0 comments Download
D Source/core/dom/TagNodeList.h View 1 chunk +0 lines, -91 lines 0 comments Download
D Source/core/dom/TagNodeList.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 2 3 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/CollectionType.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.idl View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 3 4 5 13 chunks +36 lines, -35 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebNode.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/web/WebNodeList.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +33 lines, -0 lines 0 comments Download
M public/web/WebNode.h View 2 chunks +2 lines, -1 line 0 comments Download
M public/web/WebNodeCollection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/web/WebNodeList.h View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (0 generated)
Inactive
6 years, 10 months ago (2014-01-29 03:40:35 UTC) #1
arv (Not doing code reviews)
https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt File LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt (right): https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt#newcode145 LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt:145: PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable is true length should not be ...
6 years, 10 months ago (2014-01-29 04:45:47 UTC) #2
Inactive
https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt File LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt (right): https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt#newcode145 LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt:145: PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable is true On 2014/01/29 04:45:48, arv ...
6 years, 10 months ago (2014-01-29 14:08:13 UTC) #3
Inactive
https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt File LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt (right): https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt#newcode145 LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt:145: PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable is true On 2014/01/29 04:45:48, arv ...
6 years, 10 months ago (2014-01-29 16:21:33 UTC) #4
Inactive
https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt File LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt (right): https://codereview.chromium.org/143453010/diff/40001/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt#newcode145 LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt:145: PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable is true On 2014/01/29 04:45:48, arv ...
6 years, 10 months ago (2014-01-29 21:17:35 UTC) #5
arv (Not doing code reviews)
LGTM but I would like one more reviewer to look at this. Thanks
6 years, 10 months ago (2014-01-29 21:25:17 UTC) #6
tkent
lgtm https://codereview.chromium.org/143453010/diff/140001/public/web/WebNodeList.h File public/web/WebNodeList.h (right): https://codereview.chromium.org/143453010/diff/140001/public/web/WebNodeList.h#newcode60 public/web/WebNodeList.h:60: WebNodeList(const WebNodeCollection&); I think BLINK_EXPORT is necessary.
6 years, 10 months ago (2014-01-29 22:56:40 UTC) #7
Inactive
https://codereview.chromium.org/143453010/diff/140001/public/web/WebNodeList.h File public/web/WebNodeList.h (right): https://codereview.chromium.org/143453010/diff/140001/public/web/WebNodeList.h#newcode60 public/web/WebNodeList.h:60: WebNodeList(const WebNodeCollection&); On 2014/01/29 22:56:41, tkent wrote: > I ...
6 years, 10 months ago (2014-01-29 23:53:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/143453010/70041
6 years, 10 months ago (2014-01-30 00:38:44 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/143453010/70041
6 years, 10 months ago (2014-01-30 03:04:33 UTC) #11
commit-bot: I haz the power
Change committed as 166088
6 years, 10 months ago (2014-01-30 06:19:58 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 06:20:59 UTC) #13
dglazkov
This broke a whole bunch of tests that were relying on Web* interfaces to stay ...
6 years, 10 months ago (2014-01-30 17:33:40 UTC) #14
Inactive
Reopening as this was reverted due to renderer crashes. I know how to fix it ...
6 years, 10 months ago (2014-01-30 18:14:16 UTC) #15
Inactive
On 2014/01/30 17:33:40, Dimitri Glazkov wrote: > This broke a whole bunch of tests that ...
6 years, 10 months ago (2014-01-30 18:38:24 UTC) #16
Inactive
On 2014/01/30 18:38:24, Chris Dumez wrote: > On 2014/01/30 17:33:40, Dimitri Glazkov wrote: > > ...
6 years, 10 months ago (2014-02-01 00:10:48 UTC) #17
dglazkov
lgtm.
6 years, 10 months ago (2014-02-01 00:14:43 UTC) #18
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-01 00:16:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/143453010/230001
6 years, 10 months ago (2014-02-01 00:16:56 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 01:09:42 UTC) #21
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-01 01:09:43 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 01:09:45 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 01:09:52 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 01:10:31 UTC) #25
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-01 01:36:40 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/143453010/230001
6 years, 10 months ago (2014-02-01 01:36:58 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 02:18:44 UTC) #28
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10419
6 years, 10 months ago (2014-02-01 02:18:45 UTC) #29
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 02:18:45 UTC) #30
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 02:18:47 UTC) #31
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 02:18:52 UTC) #32
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-01 21:03:18 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/143453010/230001
6 years, 10 months ago (2014-02-01 21:03:41 UTC) #34
commit-bot: I haz the power
Change committed as 166263
6 years, 10 months ago (2014-02-01 23:15:32 UTC) #35
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 23:15:32 UTC) #36
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 23:15:34 UTC) #37
commit-bot: I haz the power
6 years, 10 months ago (2014-02-01 23:15:39 UTC) #38
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698