Source/web/WebHelperPluginImpl.cpp - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebHelperPluginImpl.cpp

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebHelperPluginImpl.cpp

diff --git a/Source/web/WebHelperPluginImpl.cpp b/Source/web/WebHelperPluginImpl.cpp

index 163e40be168dea96db7569f3d38bcbc074e9ca96..bf0823689e9e225bfb70c82a9e66e61459dd5e4f 100644

--- a/Source/web/WebHelperPluginImpl.cpp

+++ b/Source/web/WebHelperPluginImpl.cpp

@@ -40,7 +40,7 @@

#include "WebViewClient.h"

#include "WebViewImpl.h"

#include "WebWidgetClient.h"

-#include "core/dom/NodeList.h"

+#include "core/html/HTMLCollection.h"

#include "core/html/HTMLPlugInElement.h"

#include "core/loader/EmptyClients.h"

#include "core/loader/FrameLoadRequest.h"

@@ -180,7 +180,7 @@ WebPlugin* WebHelperPluginImpl::getPlugin()

{

ASSERT(m_page);

- RefPtr<NodeList> objectElements = m_page->mainFrame()->document()->getElementsByTagName(WebCore::HTMLNames::objectTag.localName());

+ RefPtr<HTMLCollection> objectElements = m_page->mainFrame()->document()->getElementsByTagName(WebCore::HTMLNames::objectTag.localName());

ASSERT(objectElements && objectElements->length() == 1);

if (!objectElements || objectElements->length() < 1)

return 0;

« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/web/WebNode.cpp » ('j') | no next file with comments »