Add addFragPosUniform to GrGLrogramBuilder

Add addFragPosUniform to GrGLrogramBuilder

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/f3bace939287ca7bb02eaeb38ab51939d7e1ae98

[egdaniel, 2015-11-04 21:42:37]

egdaniel@google.com changed reviewers:
+ joshualitt@chromium.org

[egdaniel, 2015-11-04 21:42:37]

ptal

[joshualitt, 2015-11-04 21:50:51]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-11-04 21:50:52]

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
File src/gpu/gl/builders/GrGLProgramBuilder.cpp (right):

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
src/gpu/gl/builders/GrGLProgramBuilder.cpp:116: if (!fOutOfStage && mangle) {
Do we still need fOutOfStage?

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
File src/gpu/gl/builders/GrGLProgramBuilder.h (right):

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
src/gpu/gl/builders/GrGLProgramBuilder.h:76: UniformHandle
addFragPosUniform(uint32_t visibility,
However you want to handle this, it should be private so that Fragment
Processors cannot call it directly.

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
src/gpu/gl/builders/GrGLProgramBuilder.h:262: 
This should be private

[egdaniel, 2015-11-05 21:49:59]

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
File src/gpu/gl/builders/GrGLProgramBuilder.cpp (right):

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
src/gpu/gl/builders/GrGLProgramBuilder.cpp:116: if (!fOutOfStage && mangle) {
On 2015/11/04 21:50:52, joshualitt wrote:
> Do we still need fOutOfStage?

removed

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
File src/gpu/gl/builders/GrGLProgramBuilder.h (right):

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
src/gpu/gl/builders/GrGLProgramBuilder.h:76: UniformHandle
addFragPosUniform(uint32_t visibility,
On 2015/11/04 21:50:52, joshualitt wrote:
> However you want to handle this, it should be private so that Fragment
> Processors cannot call it directly.

Done.

https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
src/gpu/gl/builders/GrGLProgramBuilder.h:262: 
On 2015/11/04 21:50:52, joshualitt wrote:
> This should be private

Done.

[joshualitt, 2015-11-05 22:05:57]

On 2015/11/05 21:49:59, egdaniel wrote:
>
https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
> File src/gpu/gl/builders/GrGLProgramBuilder.cpp (right):
> 
>
https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
> src/gpu/gl/builders/GrGLProgramBuilder.cpp:116: if (!fOutOfStage && mangle) {
> On 2015/11/04 21:50:52, joshualitt wrote:
> > Do we still need fOutOfStage?
> 
> removed
> 
>
https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
> File src/gpu/gl/builders/GrGLProgramBuilder.h (right):
> 
>
https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
> src/gpu/gl/builders/GrGLProgramBuilder.h:76: UniformHandle
> addFragPosUniform(uint32_t visibility,
> On 2015/11/04 21:50:52, joshualitt wrote:
> > However you want to handle this, it should be private so that Fragment
> > Processors cannot call it directly.
> 
> Done.
> 
>
https://codereview.chromium.org/1434483002/diff/1/src/gpu/gl/builders/GrGLPro...
> src/gpu/gl/builders/GrGLProgramBuilder.h:262: 
> On 2015/11/04 21:50:52, joshualitt wrote:
> > This should be private
> 
> Done.

lgtm

[egdaniel, 2015-11-06 14:44:50]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-11-06 14:44:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434483002/20001

[commit-bot: I haz the power, 2015-11-06 14:57:14]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f3bace939287ca7bb02eaeb38ab51939d7e1ae98