bluetooth: Remove non const references from BluetoothDispatcherHost

bluetooth: Remove non const references from BluetoothDispatcherHost

We had some non-const references that broke the style guide. This
patch removes them.

BUG=551696
Committed: https://crrev.com/84061ed212a418c88b08164afede071815d51968
Cr-Commit-Position: refs/heads/master@{#360603}

[ortuno, 2015-11-13 22:19:36]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2015-11-13 22:19:37]

jyasskin: PTAL

[ortuno, 2015-11-13 22:19:43]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 22:20:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434403006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434403006/1

[Jeffrey Yasskin, 2015-11-13 23:04:47]

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:870: CacheQueryResult
query_result =
I might make all of these const, just to be clear that they don't change.

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:1266: result.outcome =
CacheQueryOutcome::BAD_RENDERER;
It might make sense to give CacheQueryResult a constructor taking an outcome, to
save a line in functions like this. Then you'd move the 'result' declaration
down to the call to QueryCacheForDevice to save another line.

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.h:214: // successful
CacheQueryResult.service will contain the service.
QueryCacheForService also fills in CacheQueryResult.device and .outcome, right?
Maybe "Fills in the |outcome| field, and the |device| and |service| fields if
successful."?

[commit-bot: I haz the power, 2015-11-13 23:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 23:46:22]

Dry run: This issue passed the CQ dry run.

[ortuno, 2015-11-18 18:43:54]

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:870: CacheQueryResult
query_result =
On 2015/11/13 at 23:04:47, Jeffrey Yasskin wrote:
> I might make all of these const, just to be clear that they don't change.

Done.

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:1266: result.outcome =
CacheQueryOutcome::BAD_RENDERER;
On 2015/11/13 at 23:04:47, Jeffrey Yasskin wrote:
> It might make sense to give CacheQueryResult a constructor taking an outcome,
to save a line in functions like this. Then you'd move the 'result' declaration
down to the call to QueryCacheForDevice to save another line.

Done.

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1434403006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.h:214: // successful
CacheQueryResult.service will contain the service.
On 2015/11/13 at 23:04:47, Jeffrey Yasskin wrote:
> QueryCacheForService also fills in CacheQueryResult.device and .outcome,
right? Maybe "Fills in the |outcome| field, and the |device| and |service|
fields if successful."?

Done. Also changed the other descriptions.

[Jeffrey Yasskin, 2015-11-18 18:53:22]

lgtm

[ortuno, 2015-11-19 16:35:53]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-11-19 16:36:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434403006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434403006/20001

[commit-bot: I haz the power, 2015-11-19 16:41:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 16:41:52]

Patchset 2 (id:??) landed as
https://crrev.com/84061ed212a418c88b08164afede071815d51968
Cr-Commit-Position: refs/heads/master@{#360603}