Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: content/browser/bluetooth/bluetooth_dispatcher_host.h

Issue 1434403006: bluetooth: Remove non const references from BluetoothDispatcherHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Address jyasskin's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/bluetooth/bluetooth_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/bluetooth/bluetooth_dispatcher_host.h
diff --git a/content/browser/bluetooth/bluetooth_dispatcher_host.h b/content/browser/bluetooth/bluetooth_dispatcher_host.h
index 5fe1f90a00bdb32f6b7500ee6ca22cac975be6e4..6f8dc21630998fdb29c4887bcb324be6130061a0 100644
--- a/content/browser/bluetooth/bluetooth_dispatcher_host.h
+++ b/content/browser/bluetooth/bluetooth_dispatcher_host.h
@@ -207,20 +207,17 @@ class CONTENT_EXPORT BluetoothDispatcherHost final
// was already recorded and since there renderer crashed there is no need to
// send a response.
- // Queries the platform cache for a Device with |device_id|. If
- // successful the device will be in result.device
- void QueryCacheForDevice(const std::string& device_id,
- CacheQueryResult& result);
- // Queries the platform cache for a Service with |service_instance_id|.
- // If successfull the service will be in result.service.
- void QueryCacheForService(const std::string& service_instance_id,
- CacheQueryResult& result);
+ // Queries the platform cache for a Device with |device_id|. Fills in the
+ // |outcome| field and the |device| field if successful.
+ CacheQueryResult QueryCacheForDevice(const std::string& device_id);
+ // Queries the platform cache for a Service with |service_instance_id|. Fills
+ // in the |outcome| field, and |device| and |service| fields if successful.
+ CacheQueryResult QueryCacheForService(const std::string& service_instance_id);
// Queries the platform cache for a characteristic with
- // |characteristic_instance_id|. If successfull the characteristic will be in
- // result.characteristic.
- void QueryCacheForCharacteristic(
- const std::string& characteristic_instance_id,
- CacheQueryResult& result);
+ // |characteristic_instance_id|. Fills in the |outcome| field, and |device|,
+ // |service| and |characteristic| fields if successful.
+ CacheQueryResult QueryCacheForCharacteristic(
+ const std::string& characteristic_instance_id);
// Returns true if all services have been discovered for the device.
// When the host gets a ServiceChanged indication, it automatically
« no previous file with comments | « no previous file | content/browser/bluetooth/bluetooth_dispatcher_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698