Issue 14341013: Pass InlinedCallData by const-reference in InlineCall() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14341013: Pass InlinedCallData by const-reference in InlineCall() function. (Closed)

Created:
7 years, 8 months ago by tfarina

Modified:
7 years, 8 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, siva, srdjan, Kevin Millikin (Chromium)

Base URL:
https://git.chromium.org/git/external/dart/bleeding_edge.git@master

Visibility:
Public.

Pass InlinedCallData by const-reference in InlineCall() function. R=srdjan@google.com,kmillikin@google.com Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View	1	4 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 6 (0 generated)

tfarina

Hi, could you review this to me? Note that I don't have dart commit access. ...

7 years, 8 months ago (2013-04-23 02:04:56 UTC) #1

tfarina

Looks like someone changed from srdjan to kmillikin. Kevin, could you take a look? Thanks,

7 years, 8 months ago (2013-04-23 17:59:39 UTC) #2

tfarina

If you see this as a cosmetic change and not as an improvement, fine! Then ...

7 years, 8 months ago (2013-04-25 14:28:51 UTC) #5

Thanks for the answer Kevin!

Closing this!