Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 14341004: FileAPI code should not rely on or assume specific MountPointProvider types (Closed)

Created:
7 years, 8 months ago by kinuko
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

FileAPI code should not rely on or assume specific MountPointProvider types To move some non-regular MountPointProviders out of webkit/fileapi, we should not: - Require FileAPI code change for a new MountPointProvider to get/set provider-specific operation context value (e.g. MediaPathFilter) - Require a new MountPointProvider type to be listed as a 'frined' of FileAPI code To avoid having these dependencies, this change: - Makes FileSystemOperationContext inherit from SupportsUserData so that MountPointProviders can get/set arbitrary user values with string keys. - Makes some private methods public (with proper comments) and remove the friend list of MountPointProviders This patch is a part of following change plan (internal only doc): https://docs.google.com/a/google.com/document/d/1XEtX0OO_RIA_c0KuKvd9yqK5l3XtsTulwXs3c-mAQ1o/view BUG=175936 TEST=content_unittests:*File* TEST=browser_tests:*MediaGalleries* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195193

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -102 lines) Patch
M webkit/fileapi/file_system_operation_context.h View 6 chunks +30 lines, -34 lines 0 comments Download
M webkit/fileapi/file_system_operation_context.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 2 chunks +21 lines, -9 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.h View 4 chunks +17 lines, -29 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 3 chunks +17 lines, -14 lines 0 comments Download
M webkit/fileapi/media/device_media_async_file_util.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/fileapi/media/native_media_file_util.cc View 9 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
Taiju: Can you take a look at fileapi changes? Steve: This one's basically fyi, but ...
7 years, 8 months ago (2013-04-18 11:24:14 UTC) #1
tzik
lgtm
7 years, 8 months ago (2013-04-18 14:34:37 UTC) #2
vandebo (ex-Chrome)
LGTM
7 years, 8 months ago (2013-04-18 21:32:19 UTC) #3
kinuko
7 years, 8 months ago (2013-04-19 14:56:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r195193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698