FileAPI code should not rely on or assume specific MountPointProvider types

webkit/fileapi/local_file_system_operation.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_OPERATION_H_
 #define WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_OPERATION_H_
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
@@ skipping 16 matching lines @@
 namespace fileapi {
 
 class AsyncFileUtil;
 class FileSystemContext;
 class RecursiveOperationDelegate;
 
 // FileSystemOperation implementation for local file systems.
 class WEBKIT_STORAGE_EXPORT LocalFileSystemOperation
     : public NON_EXPORTED_BASE(FileSystemOperation) {
  public:
+  // NOTE: This constructor should not be called outside MountPointProviders;
+  // instead please consider using
+  // file_system_context->CreateFileSystemOperation() to instantiate
+  // an appropriate FileSystemOperation.
+  LocalFileSystemOperation(
+      FileSystemContext* file_system_context,
+      scoped_ptr<FileSystemOperationContext> operation_context);
+
   virtual ~LocalFileSystemOperation();
 
   // FileSystemOperation overrides.
   virtual void CreateFile(const FileSystemURL& url,
                           bool exclusive,
                           const StatusCallback& callback) OVERRIDE;
   virtual void CreateDirectory(const FileSystemURL& url,
                                bool exclusive,
                                bool recursive,
                                const StatusCallback& callback) OVERRIDE;
@@ skipping 104 matching lines @@
   //   its parent path is a file.
   //
   void MoveFileLocal(const FileSystemURL& src_url,
                      const FileSystemURL& dest_url,
                      const StatusCallback& callback);
 
   // Synchronously gets the platform path for the given |url|.
   void SyncGetPlatformPath(const FileSystemURL& url,
                            base::FilePath* platform_path);
 
- private:
-  enum OperationMode {
-    OPERATION_MODE_READ,
-    OPERATION_MODE_WRITE,
-  };
-
-  // Only MountPointProviders or testing class can create a
-  // new operation directly.
-  friend class FileSystemTestHelper;
-  friend class IsolatedMountPointProvider;
-  friend class SandboxMountPointProvider;
-  friend class TestMountPointProvider;
-  friend class chromeos::CrosMountPointProvider;
-
-  friend class LocalFileSystemOperationTest;
-  friend class LocalFileSystemOperationWriteTest;
-  friend class FileWriterDelegateTest;
-  friend class FileSystemQuotaTest;
-  friend class LocalFileSystemTestOriginHelper;
-
-  friend class RecursiveOperationDelegate;
-  friend class CrossOperationDelegate;
-  friend class sync_file_system::SyncableFileSystemOperation;
-
-  LocalFileSystemOperation(
-      FileSystemContext* file_system_context,
-      scoped_ptr<FileSystemOperationContext> operation_context);
-
   FileSystemContext* file_system_context() const {
     return file_system_context_;
   }
 
   FileSystemOperationContext* operation_context() const {
     if (parent_operation_)
       return parent_operation_->operation_context();
     return operation_context_.get();
   }
 
+ private:
+  enum OperationMode {
+    OPERATION_MODE_READ,
+    OPERATION_MODE_WRITE,
+  };
+
+  friend class sync_file_system::SyncableFileSystemOperation;
+
   // Queries the quota and usage and then runs the given |task|.
   // If an error occurs during the quota query it runs |error_callback| instead.
   void GetUsageAndQuotaThenRunTask(
       const FileSystemURL& url,
       const base::Closure& task,
       const base::Closure& error_callback);
 
   // Called after the quota info is obtained from the quota manager
   // (which is triggered by GetUsageAndQuotaThenRunTask).
   // Sets the quota info in the operation_context_ and then runs the given
@@ skipping 100 matching lines @@
 
   scoped_refptr<FileSystemContext> file_system_context_;
 
   scoped_ptr<FileSystemOperationContext> operation_context_;
   AsyncFileUtil* async_file_util_;  // Not owned.
 
   // If this operation is created as a sub-operation for nested operation,
   // this holds non-null value and points to the parent operation.
   // TODO(kinuko): Cleanup this when we finish cleaning up the
   // FileSystemOperation lifetime issue.
-  LocalFileSystemOperation* parent_operation_;
+  base::WeakPtr<LocalFileSystemOperation> parent_operation_;
 
   // These are all used only by Write().
   friend class FileWriterDelegate;
   scoped_ptr<FileWriterDelegate> file_writer_delegate_;
 
   scoped_ptr<RecursiveOperationDelegate> recursive_operation_delegate_;
 
   // write_callback is kept in this class for so that we can dispatch it when
   // the operation is cancelled. calcel_callback is kept for canceling a
   // Truncate() operation. We can't actually stop Truncate in another thread;
@@ skipping 15 matching lines @@
   // LocalFileSystemOperation instance is usually deleted upon completion but
   // could be deleted while it has inflight callbacks when Cancel is called.
   base::WeakPtrFactory<LocalFileSystemOperation> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(LocalFileSystemOperation);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_OPERATION_H_