Implement a ShowSecurityPanel() call in the browser.

chrome/browser/devtools/devtools_window.cc

Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 41863af5b69883153a826134e32132da0dd64d0c..1105d6af7ca2fd4dd34c79a607c8a5201f2df3c9 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -455,10 +455,10 @@ void DevToolsWindow::ToggleDevToolsWindow(
     return;
   }
 
-  ToggleDevToolsWindow(
-      browser->tab_strip_model()->GetActiveWebContents(),
-      action.type() == DevToolsToggleAction::kInspect,
-      action, "");
+  bool force_open = action.type() == DevToolsToggleAction::kInspect ||
+                    action.type() == DevToolsToggleAction::kShowSecurityPanel;

[pfeldman, 2015/11/12 18:58:02]

This way it is unclear why Console behaves differently from SecurityPanel. Lets
expose a method that allows force-opening devtools with any of the actions.

[lgarron, 2015/11/13 00:03:38]

So, we may or may not need one.
The call from //c/b/ui/browser_command_controller.cc is:

browser_commands::ToggleDevToolsWindow(browser, DevToolsToggleAction action)
DevToolsWindow::ToggleDevToolsWindow(browser, action)
DevToolsWindow::ToggleDevToolsWindow(inspected_web_contents, force_open,
DevToolsToggleAction& action, settings)

However, it would, say, already be possible to call:

DevToolsWindow::OpenDevToolsWindow(browser->tab_strip_model()->GetActiveWebContents(),
DevToolsToggleAction::ShowSecurityPanel())

Are you okay with expecting code to call into DevToolsWindow() if they want to
force-open, or would you prefer a layer of indirection with
browser_command_controller?

+  ToggleDevToolsWindow(browser->tab_strip_model()->GetActiveWebContents(),

[lgarron, 2015/11/11 11:01:50]

External code can't call this private ToggleDevToolsWindow() implementation with
a custom force_open value directly, so I've opted for matching the way we
calculate force_open for Inspect().

+                       force_open, action, "");
 }
 
 // static
@@ -1201,6 +1201,11 @@ void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {
           "DevToolsAPI.showConsole", NULL, NULL, NULL);
       break;
 
+    case DevToolsToggleAction::kShowSecurityPanel:
+      bindings_->CallClientFunction("DevToolsAPI.showSecurityPanel", NULL, NULL,

[pfeldman, 2015/11/12 18:58:02]

Lets generalize to "showPanel", "security"

+                                    NULL);
+      break;
+
     case DevToolsToggleAction::kInspect:
       bindings_->CallClientFunction(
           "DevToolsAPI.enterInspectElementMode", NULL, NULL, NULL);