Implement a ShowSecurityPanel() call in the browser.

chrome/browser/devtools/devtools_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_window.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
@@ skipping 437 matching lines @@
 // static
 void DevToolsWindow::ToggleDevToolsWindow(
     Browser* browser,
     const DevToolsToggleAction& action) {
   if (action.type() == DevToolsToggleAction::kToggle &&
       browser->is_devtools()) {
     browser->tab_strip_model()->CloseAllTabs();
     return;
   }
 
-  ToggleDevToolsWindow(
-      browser->tab_strip_model()->GetActiveWebContents(),
-      action.type() == DevToolsToggleAction::kInspect,
-      action, "");
+  bool force_open = action.type() == DevToolsToggleAction::kInspect ||
+                    action.type() == DevToolsToggleAction::kShowSecurityPanel;

[pfeldman, 2015/11/12 18:58:02]

This way it is unclear why Console behaves differently from SecurityPanel. Lets
expose a method that allows force-opening devtools with any of the actions.

[lgarron, 2015/11/13 00:03:38]

So, we may or may not need one.
The call from //c/b/ui/browser_command_controller.cc is:

browser_commands::ToggleDevToolsWindow(browser, DevToolsToggleAction action)
DevToolsWindow::ToggleDevToolsWindow(browser, action)
DevToolsWindow::ToggleDevToolsWindow(inspected_web_contents, force_open,
DevToolsToggleAction& action, settings)

However, it would, say, already be possible to call:

DevToolsWindow::OpenDevToolsWindow(browser->tab_strip_model()->GetActiveWebContents(),
DevToolsToggleAction::ShowSecurityPanel())

Are you okay with expecting code to call into DevToolsWindow() if they want to
force-open, or would you prefer a layer of indirection with
browser_command_controller?

+  ToggleDevToolsWindow(browser->tab_strip_model()->GetActiveWebContents(),

[lgarron, 2015/11/11 11:01:50]

External code can't call this private ToggleDevToolsWindow() implementation with
a custom force_open value directly, so I've opted for matching the way we
calculate force_open for Inspect().

+                       force_open, action, "");
 }
 
 // static
 void DevToolsWindow::OpenExternalFrontend(
     Profile* profile,
     const std::string& frontend_url,
     const scoped_refptr<content::DevToolsAgentHost>& agent_host,
     bool isWorker) {
   DevToolsWindow* window = FindDevToolsWindow(agent_host.get());
   if (!window) {
@@ skipping 722 matching lines @@
       browser->window() : NULL;
 }
 
 void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {
   switch (action.type()) {
     case DevToolsToggleAction::kShowConsole:
       bindings_->CallClientFunction(
           "DevToolsAPI.showConsole", NULL, NULL, NULL);
       break;
 
+    case DevToolsToggleAction::kShowSecurityPanel:
+      bindings_->CallClientFunction("DevToolsAPI.showSecurityPanel", NULL, NULL,

[pfeldman, 2015/11/12 18:58:02]

Lets generalize to "showPanel", "security"

+                                    NULL);
+      break;
+
     case DevToolsToggleAction::kInspect:
       bindings_->CallClientFunction(
           "DevToolsAPI.enterInspectElementMode", NULL, NULL, NULL);
       break;
 
     case DevToolsToggleAction::kShow:
     case DevToolsToggleAction::kToggle:
       // Do nothing.
       break;
 
@@ skipping 59 matching lines @@
 bool DevToolsWindow::ReloadInspectedWebContents(bool ignore_cache) {
   // Only route reload via front-end if the agent is attached.
   WebContents* wc = GetInspectedWebContents();
   if (!wc || wc->GetCrashedStatus() != base::TERMINATION_STATUS_STILL_RUNNING)
     return false;
   base::FundamentalValue ignore_cache_value(ignore_cache);
   bindings_->CallClientFunction("DevToolsAPI.reloadInspectedPage",
                                 &ignore_cache_value, nullptr, nullptr);
   return true;
 }