Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 1433933007: [headless] Create headless/ folder (Closed)

Created:
5 years, 1 month ago by altimin
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Create headless/ folder Create top-level headless/ folder and OWNERS for it. BUG=546953 Committed: https://crrev.com/711497d0138297f221cd7283f313e6254b0409fe Cr-Commit-Position: refs/heads/master@{#360095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
A + headless/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
altimin
5 years, 1 month ago (2015-11-13 13:41:34 UTC) #3
jam
curious why we need a toplevel folder for this? what will go here?
5 years, 1 month ago (2015-11-13 17:16:12 UTC) #4
alex clarke (OOO till 29th)
On 2015/11/13 17:16:12, jam wrote: > curious why we need a toplevel folder for this? ...
5 years, 1 month ago (2015-11-13 17:23:39 UTC) #5
altimin
On 2015/11/13 17:23:39, alexclarke1 wrote: > On 2015/11/13 17:16:12, jam wrote: > > curious why ...
5 years, 1 month ago (2015-11-13 23:59:16 UTC) #6
Sami
FWIW, we chose a toplevel folder instead of something inside content/ to make it clear ...
5 years, 1 month ago (2015-11-16 09:59:30 UTC) #7
Sami
Ping, any thoughts on this?
5 years, 1 month ago (2015-11-17 14:23:14 UTC) #9
jam
On 2015/11/16 09:59:30, Sami wrote: > FWIW, we chose a toplevel folder instead of something ...
5 years, 1 month ago (2015-11-17 15:44:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433933007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433933007/1
5 years, 1 month ago (2015-11-17 16:48:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 17:05:43 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 17:06:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/711497d0138297f221cd7283f313e6254b0409fe
Cr-Commit-Position: refs/heads/master@{#360095}

Powered by Google App Engine
This is Rietveld 408576698