headless: Add a headless shell

headless: Add a headless shell

Introduce a headless shell executable that can be used to test the
headless configuration of Chrome and exercise various headless APIs.

BUG=546953

[Sami, 2015-10-23 16:38:47]

Description was changed from

==========
headless: Add a headless test shell

Introduce a headless test shell executable that can be used to test the
headless configuration of Chrome and exercise various headless APIs.

BUG=546953
==========

to

==========
headless: Add a headless test shell

Introduce a headless test shell executable that can be used to test the
headless configuration of Chrome and exercise various headless APIs.

BUG=546953
==========

[Sami, 2015-10-23 16:39:15]

Still needs some cleanup. Sample command line:

out_linux/Debug/headless_test_shell --ozone-platform=test --disable-gpu
--single-process --ozone-dump-file=/tmp/headless http://www.google.com

[Sami, 2015-10-26 15:57:39]

skyostil@chromium.org changed reviewers:
+ peter@chromium.org

[Sami, 2015-10-26 15:58:11]

Peter, wanna have a look? Feel free to suggest a better way of adding a tool
like this if you can think of one.

[Sami, 2015-10-26 19:49:36]

Description was changed from

==========
headless: Add a headless test shell

Introduce a headless test shell executable that can be used to test the
headless configuration of Chrome and exercise various headless APIs.

BUG=546953
==========

to

==========
headless: Add a headless shell

Introduce a headless shell executable that can be used to test the
headless configuration of Chrome and exercise various headless APIs.

BUG=546953
==========

[Sami, 2015-10-26 19:51:21]

Moved to a top level directory like we discussed. WDYT of the layout now? Also,
doesn't seem to generate any pngs any longer which I need to figure out :)

[Peter Beverloo, 2015-10-27 14:35:51]

A few nits - thank you for moving it, this seems more appropriate to me than a
sub-target in //content/shell/.

Perhaps ask jam@ to do the addition review, given that he's a member of the
mailing list and will have context?

https://codereview.chromium.org/1410573004/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1410573004/diff/60001/BUILD.gn#newcode649
BUILD.gn:649: if (is_headless) {
Does this need to be defined somewhere?

Documenting it in //tools/gn/docs/cookbook.md also seems appropriate.

https://codereview.chromium.org/1410573004/diff/60001/headless/README.md
File headless/README.md (right):

https://codereview.chromium.org/1410573004/diff/60001/headless/README.md#newc...
headless/README.md:13: 2. A sample application which demonstrates the use of
headless APIs.
Perhaps //headless/app/ would be more appropriately named as //headless/shell/?
(Also per your comment under testing.)

https://codereview.chromium.org/1410573004/diff/60001/headless/app/BUILD.gn
File headless/app/BUILD.gn (right):

https://codereview.chromium.org/1410573004/diff/60001/headless/app/BUILD.gn#n...
headless/app/BUILD.gn:1: import("//build/config/features.gni")
nit: copyright header

https://codereview.chromium.org/1410573004/diff/60001/headless/lib/BUILD.gn
File headless/lib/BUILD.gn (right):

https://codereview.chromium.org/1410573004/diff/60001/headless/lib/BUILD.gn#n...
headless/lib/BUILD.gn:1: import("//build/config/features.gni")
nit: copyright header

https://codereview.chromium.org/1410573004/diff/60001/headless/lib/headless_m...
File headless/lib/headless_main_delegate.cc (right):

https://codereview.chromium.org/1410573004/diff/60001/headless/lib/headless_m...
headless/lib/headless_main_delegate.cc:94: bool r =
PathService::Get(base::DIR_MODULE, &pak_file);
nit: const bool success?

https://codereview.chromium.org/1410573004/diff/60001/headless/lib/headless_m...
headless/lib/headless_main_delegate.cc:96: pak_file =
pak_file.Append(FILE_PATH_LITERAL("content_shell.pak"));
headless.pak