Issue 143363003: Experimental parser: tiny fix for silly code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143363003: Experimental parser: tiny fix for silly code. (Closed)

Created:
6 years, 11 months ago by marja

Modified:
6 years, 11 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: tiny fix for silly code. TBR=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18693

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	src/parser.cc	View		1 chunk	+4 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

Committed patchset #1 manually as r18693 (presubmit successful).

6 years, 11 months ago (2014-01-20 14:52:00 UTC) #1

ulan

6 years, 11 months ago (2014-01-20 14:54:27 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/143363003/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/143363003/diff/1/src/parser.cc#newcode574
src/parser.cc:574: scanner_ = new ExperimentalScanner<uint8_t>(source,
isolate());
Please wrap the branches in { } since they are in a separate line.

Expand Messages | Collapse Messages