Experimental parser: tiny fix for silly code.

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 548 matching lines @@
   isolate()->counters()->total_parse_size()->Increment(source->length());
   ElapsedTimer timer;
   if (FLAG_trace_parse) {
     timer.Start();
   }
   fni_ = new(zone()) FuncNameInferrer(isolate(), zone());
 
   // Initialize parser state.
   source = FlattenGetString(source);
   FunctionLiteral* result;
-  if (source->IsTwoByteRepresentation()) {
-    delete reusable_preparser_;
-    delete scanner_;
+  delete reusable_preparser_;
+  delete scanner_;
+  if (source->IsTwoByteRepresentation())
     scanner_ = new ExperimentalScanner<uint16_t>(source, isolate());
-  } else {
-    delete reusable_preparser_;
-    delete scanner_;
+  else
     scanner_ = new ExperimentalScanner<uint8_t>(source, isolate());

[ulan, 2014/01/20 14:54:28]

Please wrap the branches in { } since they are in a separate line.

-  }
   SetScannerFlags();
   scanner_->Init();
   result = DoParseProgram(info(), source);
 
   if (FLAG_trace_parse && result != NULL) {
     double ms = timer.Elapsed().InMillisecondsF();
     if (info()->is_eval()) {
       PrintF("[parsing eval");
     } else if (info()->script()->name()->IsString()) {
       String* name = String::cast(info()->script()->name());
@@ skipping 5100 matching lines @@
 }
 
 
 void Parser::SetScannerFlags() {
   scanner_->SetHarmonyScoping(allow_harmony_scoping_);
   scanner_->SetHarmonyModules(allow_harmony_modules_);
   scanner_->SetHarmonyNumericLiterals(allow_harmony_numeric_literals_);
 }
 
 } }  // namespace v8::internal