Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1433623002: Devtools Animations: Don't wait for empty transitions to start (Closed)

Created:
5 years, 1 month ago by samli
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, Inactive, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools Animations: Don't wait for empty transitions to start Some animations can be triggered but never started, such as transitions which are synchronously triggered and cancelled in the same frame. As these animations are never started, the front-end needs to be notified to not wait for these animations to start. BUG=447083 Committed: https://crrev.com/17c1e863ea421cc8583a749120edba9e35e98a31 Cr-Commit-Position: refs/heads/master@{#358739}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-cancel.html View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-cancel-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-empty-transition-cancel.html View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-empty-transition-cancel-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 2 3 4 chunks +20 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
samli
5 years, 1 month ago (2015-11-06 23:06:49 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1433623002/diff/40001/third_party/WebKit/Source/devtools/protocol.json File third_party/WebKit/Source/devtools/protocol.json (right): https://codereview.chromium.org/1433623002/diff/40001/third_party/WebKit/Source/devtools/protocol.json#newcode5169 third_party/WebKit/Source/devtools/protocol.json:5169: "name": "animationCancelled", animationCanceled as American English would put ...
5 years, 1 month ago (2015-11-09 23:00:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433623002/60001
5 years, 1 month ago (2015-11-10 00:00:56 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-10 01:50:47 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 01:52:31 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/17c1e863ea421cc8583a749120edba9e35e98a31
Cr-Commit-Position: refs/heads/master@{#358739}

Powered by Google App Engine
This is Rietveld 408576698