Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1433463002: Allocate some data structures in old instead of in new space. Early inlining bailout for native fun… (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allocate some data structures in old instead of in new space. Early inlining bailout for native functions. Verify heap after background compiler was shutdown. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/8e27f43f361946cf036a24e38603cca9417d5232

Patch Set 1 #

Patch Set 2 : sync #

Total comments: 2

Patch Set 3 : Spelling error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M runtime/vm/compiler.cc View 1 2 6 chunks +19 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 1 month ago (2015-11-02 23:37:17 UTC) #2
siva
lgtm https://codereview.chromium.org/1433463002/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1433463002/diff/20001/runtime/vm/compiler.cc#newcode1812 runtime/vm/compiler.cc:1812: // queues while inseide a MonitorLocker. Will replace ...
5 years, 1 month ago (2015-11-03 00:27:31 UTC) #3
srdjan
https://codereview.chromium.org/1433463002/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1433463002/diff/20001/runtime/vm/compiler.cc#newcode1812 runtime/vm/compiler.cc:1812: // queues while inseide a MonitorLocker. Will replace GrowableObjectArray ...
5 years, 1 month ago (2015-11-03 00:37:47 UTC) #4
srdjan
5 years, 1 month ago (2015-11-03 00:39:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8e27f43f361946cf036a24e38603cca9417d5232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698