Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: runtime/vm/isolate.cc

Issue 1433463002: Allocate some data structures in old instead of in new space. Early inlining bailout for native fun… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Spelling error Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index f443e17b97ac02b76a2496408ad36e804e00e04f..997be09b3749453806a888a3e29f765b8b911383 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1649,6 +1649,9 @@ void Isolate::LowLevelShutdown() {
void Isolate::Shutdown() {
ASSERT(this == Isolate::Current());
+ // Wait until all background compilation has finished.
+ BackgroundCompiler::Stop(background_compiler_);
+
#if defined(DEBUG)
if (heap_ != NULL) {
// The VM isolate keeps all objects marked.
@@ -1656,9 +1659,6 @@ void Isolate::Shutdown() {
}
#endif // DEBUG
- // Wait until all background compilation has finished.
- BackgroundCompiler::Stop(background_compiler_);
-
Thread* thread = Thread::Current();
// Don't allow anymore dart code to execution on this isolate.
@@ -1938,6 +1938,7 @@ void Isolate::set_default_tag(const UserTag& tag) {
void Isolate::set_deoptimized_code_array(const GrowableObjectArray& value) {
+ ASSERT(Thread::Current()->IsMutatorThread());
deoptimized_code_array_ = value.raw();
}
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698