Issue 1433353007: Drop default port number in `http_server.py` and `shell.py`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1433353007: Drop default port number in `http_server.py` and `shell.py`. (Closed)

Created:
5 years, 1 month ago by ppi

Modified:
5 years, 1 month ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Description

Drop default port number in `http_server.py` and `shell.py`. It turns out nothing was using these defaults outside of `http_server_unittest.py`. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2e6ef79dc1d9bf56e15eaff0994b0344820cd911

Patch Set 1 #

Created: 5 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)
M	mojo/devtools/common/devtoolslib/android_shell.py	View	1 chunk	+1 line, -1 line	0 comments
M	mojo/devtools/common/devtoolslib/http_server.py	View	1 chunk	+1 line, -1 line	0 comments
M	mojo/devtools/common/devtoolslib/http_server_unittest.py	View	5 chunks	+5 lines, -5 lines	0 comments
M	mojo/devtools/common/devtoolslib/linux_shell.py	View	1 chunk	+1 line, -1 line	0 comments
M	mojo/devtools/common/devtoolslib/shell.py	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 1 month ago (2015-11-12 13:21:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2e6ef79dc1d9bf56e15eaff0994b0344820cd911 (presubmit successful).

Expand Messages | Collapse Messages