mojo/devtools/common/devtoolslib/android_shell.py - Issue 1433353007: Drop default port number in `http_server.py` and `shell.py`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/devtoolslib/android_shell.py

Issue 1433353007: Drop default port number in `http_server.py` and `shell.py`. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/devtoolslib/android_shell.py

diff --git a/mojo/devtools/common/devtoolslib/android_shell.py b/mojo/devtools/common/devtoolslib/android_shell.py

index 7f69c08b0a956402262313f9a5d79927ae15a721..bd0e68449f3d6379e6b006b876a48f98a277176e 100644

--- a/mojo/devtools/common/devtoolslib/android_shell.py

+++ b/mojo/devtools/common/devtoolslib/android_shell.py

@@ -421,7 +421,7 @@ class AndroidShell(Shell):

logcat_watch_thread.start()

@overrides(Shell)

- def serve_local_directories(self, mappings, port=0, reuse_servers=False):

+ def serve_local_directories(self, mappings, port, reuse_servers=False):

assert mappings

if reuse_servers:

assert port, 'Cannot reuse the server when |port| is 0.'

« no previous file with comments | « no previous file | mojo/devtools/common/devtoolslib/http_server.py » ('j') | no next file with comments »