Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: Source/core/dom/RenderTreeBuilder.h

Issue 143323014: *** DO NOT LAND *** Attempt to understand Regions complexity Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/PseudoElement.cpp ('k') | Source/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 16 matching lines...) Expand all
27 #define RenderTreeBuilder_h 27 #define RenderTreeBuilder_h
28 28
29 #include "core/dom/Document.h" 29 #include "core/dom/Document.h"
30 #include "core/dom/Node.h" 30 #include "core/dom/Node.h"
31 #include "core/dom/NodeRenderingTraversal.h" 31 #include "core/dom/NodeRenderingTraversal.h"
32 #include "wtf/RefPtr.h" 32 #include "wtf/RefPtr.h"
33 33
34 namespace WebCore { 34 namespace WebCore {
35 35
36 class ContainerNode; 36 class ContainerNode;
37 class RenderNamedFlowThread;
38 class RenderObject; 37 class RenderObject;
39 class RenderStyle; 38 class RenderStyle;
40 39
41 class RenderTreeBuilder { 40 class RenderTreeBuilder {
42 public: 41 public:
43 RenderTreeBuilder(Node* node, RenderStyle* style) 42 RenderTreeBuilder(Node* node, RenderStyle* style)
44 : m_node(node) 43 : m_node(node)
45 , m_renderingParent(0) 44 , m_renderingParent(0)
46 , m_style(style) 45 , m_style(style)
47 , m_parentFlowRenderer(0)
48 { 46 {
49 ASSERT(!node->renderer()); 47 ASSERT(!node->renderer());
50 ASSERT(node->needsAttach()); 48 ASSERT(node->needsAttach());
51 ASSERT(node->document().inStyleRecalc()); 49 ASSERT(node->document().inStyleRecalc());
52 50
53 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called 51 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called
54 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations 52 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
55 // will trigger a layout inside childrenChanged. 53 // will trigger a layout inside childrenChanged.
56 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange 54 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange
57 // which does an updateLayoutIgnorePendingStylesheets. 55 // which does an updateLayoutIgnorePendingStylesheets.
58 56
59 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetail s); 57 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetail s);
60 } 58 }
61 59
62 void createRendererForTextIfNeeded(); 60 void createRendererForTextIfNeeded();
63 void createRendererForElementIfNeeded(); 61 void createRendererForElementIfNeeded();
64 62
65 private: 63 private:
66 RenderObject* parentRenderer() const; 64 RenderObject* parentRenderer() const;
67 RenderObject* nextRenderer() const; 65 RenderObject* nextRenderer() const;
68 bool shouldCreateRenderer() const; 66 bool shouldCreateRenderer() const;
69 RenderStyle& style() const; 67 RenderStyle& style() const;
70 68
71 bool shouldMoveToFlowThread() const;
72 void moveToFlowThreadIfNeeded();
73 bool elementInsideRegionNeedsRenderer();
74
75 Node* m_node; 69 Node* m_node;
76 ContainerNode* m_renderingParent; 70 ContainerNode* m_renderingParent;
77 NodeRenderingTraversal::ParentDetails m_parentDetails; 71 NodeRenderingTraversal::ParentDetails m_parentDetails;
78 mutable RefPtr<RenderStyle> m_style; 72 mutable RefPtr<RenderStyle> m_style;
79 RenderNamedFlowThread* m_parentFlowRenderer;
80 }; 73 };
81 74
82 } // namespace WebCore 75 } // namespace WebCore
83 76
84 #endif 77 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/PseudoElement.cpp ('k') | Source/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698